[unifi] Fix online/blocked channels after client is disconnected

[jlaur]

Fixes #7001

Signed-off-by: Jacob Laursen [email protected]

Fixes a problem with the online channel never being updated to OFF after client disconnects. This was most likely introduced by Uni-Fi Controller 5.12.35. The same problem impacted the blocked channel also in the way that unblocking was not possible.

This pull request replaces #11410 with a better approach. Previous PR would keep clients in the cache after they are no longer connected to the access point. This worked for the online channel, but broke the blocked channel as a blocked client would immediately be disconnected from AP, but kept in client cache. This resulted in blocked status going back to unblocked since this was last known status.

New approach chosen is to keep a map of cid (configured key) -> _id values. When _id is returned by controller for the first time, it's kept in this cache and preferred for subsequent lookups. When client disconnects, it can no longer be found in client cache by either _id nor cid. It can however still be found in insights cache by _id. This fixes the problem as the insights cache doesn't contain IP address since controller version 5.12.35 release in beginning of 2020.

Example

When online (other clients/insights removed):

2021-10-17 22:05:37.731 [DEBUG] [i.internal.api.model.UniFiController] - Found 16 UniFi Client(s): 
 - UniFiClient{id: '5f5a2cb946e0fb0015cb4a68', mac: 'xx:xx:xx:xx:1a:79', ip: '192.168.0.28', hostname: 'oneplus-8', alias: 'oneplus 8 jacob', wired: false, blocked: false, device: UniFiDevice{id: '5cc8962d46e0fb0016dc486c', mac: 'b4:fb:e4:ca:a2:6c', name: 'Skynet', model: 'U7NHD', site: UniFiSite{name: 'oc9023uo', desc: 'Skynet'}}}
2021-10-17 22:05:37.755 [DEBUG] [i.internal.api.model.UniFiController] - Found 19 UniFi Insights(s): 
 - UniFiClient{id: '5f5a2cb946e0fb0015cb4a68', mac: 'xx:xx:xx:xx:1a:79', ip: 'null', hostname: 'oneplus-8', alias: 'oneplus 8 jacob', wired: false, blocked: false, device: null}

After going offline:

2021-10-17 22:05:47.864 [DEBUG] [i.internal.api.model.UniFiController] - Found 15 UniFi Client(s): 
2021-10-17 22:05:47.885 [DEBUG] [i.internal.api.model.UniFiController] - Found 19 UniFi Insights(s): 
 - UniFiClient{id: '5f5a2cb946e0fb0015cb4a68', mac: 'xx:xx:xx:xx:1a:79', ip: 'null', hostname: 'oneplus-8', alias: 'oneplus 8 jacob', wired: false, blocked: false, device: null}

[jlaur]

JAR: https://drive.google.com/file/d/1ikyB6ngcpcxvDofD7nkGyaBC3DlV-NFq/view?usp=sharing

[kaikreuzer]

Thanks!