Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Luxtronik] Fix possible out of bound error for older heatpumps #11318

Merged
merged 2 commits into from
Sep 28, 2021
Merged

[Luxtronik] Fix possible out of bound error for older heatpumps #11318

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e820762
[Luxtronik] Fix possible out ouf bound error for older heatpumps
sgiehl Sep 27, 2021
06460e5
fix typo
sgiehl Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tpump/src/main/java/org/openhab/binding/luxtronikheatpump/internal/HeatpumpConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void read() throws UnknownHostException, IOException {
// the thermal energies can be unreasonably high in some cases, probably due to a sign bug in the firmware
// trying to correct this issue here
for (int i = 151; i <= 154; i++) {
if (heatpumpValues[i] >= 214748364) {
if (heatpumpValues.length >= i && heatpumpValues[i] >= 214748364) {
sgiehl marked this conversation as resolved.
Show resolved Hide resolved
heatpumpValues[i] -= 214748364;
}
}
Expand Down