[Tapocontrol] Binding to control Tapo (by TP-Link) Devices #11111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildcs
changed the title
fwolter
added
the
new binding
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/tapocontrol-new-binding-for-tapo-smart-wifi-device/118389/1 |
fwolter
requested changes
Sep 5, 2021
fwolter
reviewed
Sep 12, 2021
fwolter
requested changes
Oct 30, 2021
There was a problem hiding this comment.
The credential configuration looks good!
There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.
There are some compiler warnings about null access left. You could take a look at mvn clean install. To fix these, you need to store the field to a local variable and do the null check on that.
The sign off message needs to be your full name and have a valid email address. You can post the complete line in the comments, I will adopt it during merging, then.
...control/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlConfiguration.java
Outdated
Show resolved
Hide resolved
...ocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlThingHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoSmartBulb.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
wildcs
requested review from
bern77,
bruestel,
cdjackson,
claell,
clinique,
computergeek1507,
cweitkamp,
daMihe,
davidgraeff,
digitaldan,
gerrieg,
Hilbrand,
hmerk,
kaikreuzer,
kgoderis,
lolodomo,
lujop,
marcelrv,
markus7017,
mherwege,
mhilbush,
octa22 and
pacive
as code owners
wborn
reviewed
Nov 8, 2021
|
Thanks very very much to @daMihe to help me fixing my github history. |
Signed-off-by: Christian Wild <[email protected]>
fwolter
requested changes
Nov 8, 2021
...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Outdated
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Outdated
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Outdated
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Outdated
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Outdated
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Outdated
Show resolved
Hide resolved
Would be great if you can review it all. So i can fix all review remarks next week. Binding looks to work good in that version so no bigger changes should be necessary at the moment. |
fwolter
requested changes
Nov 13, 2021
There was a problem hiding this comment.
There are some compiler warnings about null access left. You could take a look at mvn clean install. To fix these, you need to store the field to a local variable and do the null check on that.
There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.
...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java
Show resolved
Hide resolved
...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java
Outdated
Show resolved
Hide resolved
...ntrol/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoUniversalDevice.java
Outdated
Show resolved
Hide resolved
...ntrol/src/main/java/org/openhab/binding/tapocontrol/internal/structures/TapoLightEffect.java
Outdated
Show resolved
Hide resolved
...binding.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/test/TapoUDP.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/testdevice.xml
Outdated
Show resolved
Hide resolved
|
So guys. I think i resolved all review-requests. Anyway big THX to all reviewers (of any plugin etc.) for the time you spent into this and help others to get better 👍 👍 |
Signed-off-by: Christian Wild <[email protected]>
fwolter
requested changes
Nov 21, 2021
Signed-off-by: Christian Wild <[email protected]>
|
Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website |
wildcs
added a commit
to wildcs/openhab-docs
that referenced
this pull request
Dec 2, 2021
added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111
wildcs
added a commit
to wildcs/openhab-docs
that referenced
this pull request
Dec 2, 2021
added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111 Signed-off-by: Christian Wild <christianwild-bw.de>
Confectrician
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Dec 2, 2021
added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111 Signed-off-by: Christian Wild <christianwild-bw.de>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <[email protected]> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TapoControl
this is the initial contribution of a new binding to control "Tapo SmartDevices"
Control Tapo (TP-Link) P100 WiFi-Sockets, L510 and 530 SmartBulbs with openhab
It's possible to switch the devices On/Off, change colors and brighness (if supported) and gather some informations from the devices.
The connection will be established between openhab and the device directly by ip-adresses but credentials for Tapo-cloud are required because the communication is encrypted with them.
compiled with maven and testet with the vs-code-developer-ide and one openhabian device
link to the source
link to the .jar