Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yamahareceiver] Add possiblity to switch HDMI outputs on and off on Yamaha receivers #11063

Merged

Conversation

fragger42
Copy link
Contributor

[yamahareceiver] Add possiblity to switch HDMI outputs on and off on Yamaha receivers

This is an improvement to add channels that allow switching the HDMI1 Output and HDMI2 Output on and off on some Yamaha receivers. The readme lists the two new channels.

@hmerk
Copy link
Contributor

hmerk commented Jul 29, 2021

@fragger42 Thanks for your contribution. It seems you forgot to add your changes to the tests, therefor the PR build is failing.
Could you please update the tests as well, so the build is ok.

Main_Zone XML doc instead of fetching it by separate requests.

Signed-off-by: Bernhard Gruber <[email protected]>
@fragger42
Copy link
Contributor Author

@hmerk: The problem seems to be that I did separate requests to get the current state instead of using the Main_Zone XML document where the information is also provided. These requests then resulted in a Null pointer exception because they don't work on the build server. I just committed the change and on my local eclipse the tests work again. Hopefully, now everything is ok.

@hmerk
Copy link
Contributor

hmerk commented Jul 29, 2021

@fragger42 Great, let's wait and see if Jenkins is happy again ...

@fragger42
Copy link
Contributor Author

@hmerk: Seems like it worked fine ;)

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 882374f into openhab:main Jul 31, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Jul 31, 2021
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Jul 31, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
…Yamaha receivers (openhab#6327) (openhab#11063)

* Add possiblity to switch HDMI outputs on and off on Yamaha receivers
(openhab#6327)

Signed-off-by: Bernhard Gruber <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…Yamaha receivers (openhab#6327) (openhab#11063)

* Add possiblity to switch HDMI outputs on and off on Yamaha receivers
(openhab#6327)

Signed-off-by: Bernhard Gruber <[email protected]>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
…Yamaha receivers (openhab#6327) (openhab#11063)

* Add possiblity to switch HDMI outputs on and off on Yamaha receivers
(openhab#6327)

Signed-off-by: Bernhard Gruber <[email protected]>
Signed-off-by: Dave J Schoepel <[email protected]>
@wborn wborn changed the title [yamahareceiver] Add possiblity to switch HDMI outputs on and off on Yamaha receivers (openhab#6327) [yamahareceiver] Add possiblity to switch HDMI outputs on and off on Yamaha receivers Dec 18, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…Yamaha receivers (openhab#6327) (openhab#11063)

* Add possiblity to switch HDMI outputs on and off on Yamaha receivers
(openhab#6327)

Signed-off-by: Bernhard Gruber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants