-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yamahareceiver] Add possiblity to switch HDMI outputs on and off on Yamaha receivers #11063
[yamahareceiver] Add possiblity to switch HDMI outputs on and off on Yamaha receivers #11063
Conversation
(openhab#6327) Signed-off-by: Bernhard Gruber <[email protected]>
Signed-off-by: Bernhard Gruber <[email protected]>
@fragger42 Thanks for your contribution. It seems you forgot to add your changes to the tests, therefor the PR build is failing. |
Main_Zone XML doc instead of fetching it by separate requests. Signed-off-by: Bernhard Gruber <[email protected]>
@hmerk: The problem seems to be that I did separate requests to get the current state instead of using the Main_Zone XML document where the information is also provided. These requests then resulted in a Null pointer exception because they don't work on the build server. I just committed the change and on my local eclipse the tests work again. Hopefully, now everything is ok. |
@fragger42 Great, let's wait and see if Jenkins is happy again ... |
@hmerk: Seems like it worked fine ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
…Yamaha receivers (openhab#6327) (openhab#11063) * Add possiblity to switch HDMI outputs on and off on Yamaha receivers (openhab#6327) Signed-off-by: Bernhard Gruber <[email protected]>
…Yamaha receivers (openhab#6327) (openhab#11063) * Add possiblity to switch HDMI outputs on and off on Yamaha receivers (openhab#6327) Signed-off-by: Bernhard Gruber <[email protected]>
…Yamaha receivers (openhab#6327) (openhab#11063) * Add possiblity to switch HDMI outputs on and off on Yamaha receivers (openhab#6327) Signed-off-by: Bernhard Gruber <[email protected]> Signed-off-by: Dave J Schoepel <[email protected]>
…Yamaha receivers (openhab#6327) (openhab#11063) * Add possiblity to switch HDMI outputs on and off on Yamaha receivers (openhab#6327) Signed-off-by: Bernhard Gruber <[email protected]>
[yamahareceiver] Add possiblity to switch HDMI outputs on and off on Yamaha receivers
This is an improvement to add channels that allow switching the HDMI1 Output and HDMI2 Output on and off on some Yamaha receivers. The readme lists the two new channels.