Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Add new custom refresh methods and improve response to channel matching #10957

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Jul 6, 2021

  • Improve matching the command responses to the sending channel
  • Use newer method to get device list using device_list_page
  • Adding the ability to send custom requests to cloud
  • Adding the ability to send custom commands with additional elements in the json

Signed-off-by: Marcel Verpaalen [email protected]

* Improve matching the command responses to the sending channel
* Use newer method to get device list using `device_list_page`
* Adding the ability to send custom requests to cloud
* Adding the ability to send custom commands with additional elements in
the json

Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv added the enhancement An enhancement or new feature for an existing add-on label Jul 6, 2021
@marcelrv marcelrv requested a review from fwolter July 7, 2021 06:07
@kaikreuzer kaikreuzer changed the title [miio] add new custom refresh methods and improve response to channel matching [miio] Add new custom refresh methods and improve response to channel matching Jul 12, 2021
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 072a604 into openhab:main Jul 12, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Jul 12, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
* Improve matching the command responses to the sending channel
* Use newer method to get device list using `device_list_page`
* Adding the ability to send custom requests to cloud
* Adding the ability to send custom commands with additional elements in
the json

Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv deleted the miio-customCommands branch July 18, 2021 18:23
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
* Improve matching the command responses to the sending channel
* Use newer method to get device list using `device_list_page`
* Adding the ability to send custom requests to cloud
* Adding the ability to send custom commands with additional elements in
the json

Signed-off-by: Marcel Verpaalen <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* Improve matching the command responses to the sending channel
* Use newer method to get device list using `device_list_page`
* Adding the ability to send custom requests to cloud
* Adding the ability to send custom commands with additional elements in
the json

Signed-off-by: Marcel Verpaalen <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Improve matching the command responses to the sending channel
* Use newer method to get device list using `device_list_page`
* Adding the ability to send custom requests to cloud
* Adding the ability to send custom commands with additional elements in
the json

Signed-off-by: Marcel Verpaalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants