[homeconnect] Predefined temp / spin speeds options for unsupported washer programs #10953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
enhancement
|
This PR is in fact ready but as code is based on PR #10929, we need to first wait for the merge of the other PR. |
lolodomo
force-pushed
the
unsupportedprogramoptions
branch
from
ac46039 to
35b6e35
Compare
lolodomo
force-pushed
the
unsupportedprogramoptions
branch
from
35b6e35 to
a34e00f
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/home-connect-addon-looking-for-beta-testers/49702/890 |
|
@bruestel : this enhancement is now finished and ready for a review. So if you have time and availability... |
lolodomo
force-pushed
the
unsupportedprogramoptions
branch
from
a34e00f to
24ed800
Compare
…asher programs Fix openhab#10701 Also save in programs cache the unuspported program Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
force-pushed
the
unsupportedprogramoptions
branch
from
24ed800 to
09bf3e2
Compare
lolodomo
added
rebuild
bruestel
reviewed
Jul 19, 2021
...src/main/java/org/openhab/binding/homeconnect/internal/handler/HomeConnectWasherHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openhab/binding/homeconnect/internal/handler/HomeConnectWasherHandler.java
Outdated
Show resolved
Hide resolved
...n/java/org/openhab/binding/homeconnect/internal/handler/AbstractHomeConnectThingHandler.java
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
bruestel
approved these changes
Jul 21, 2021
|
@fwolter : could you please review ? |
|
Thank you @fwolter |
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…asher programs (openhab#10953) * [homeconnect] Predefined temp / spin speeds options for unsupported washer programs Fix openhab#10701 Also save in programs cache the unuspported program Signed-off-by: Laurent Garnier <[email protected]> * Use constants OPTION_WASHER_TEMPERATURE and OPTION_WASHER_SPIN_SPEED Signed-off-by: Laurent Garnier <[email protected]> * Review comment : using constants Signed-off-by: Laurent Garnier <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…asher programs (openhab#10953) * [homeconnect] Predefined temp / spin speeds options for unsupported washer programs Fix openhab#10701 Also save in programs cache the unuspported program Signed-off-by: Laurent Garnier <[email protected]> * Use constants OPTION_WASHER_TEMPERATURE and OPTION_WASHER_SPIN_SPEED Signed-off-by: Laurent Garnier <[email protected]> * Review comment : using constants Signed-off-by: Laurent Garnier <[email protected]>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…asher programs (openhab#10953) * [homeconnect] Predefined temp / spin speeds options for unsupported washer programs Fix openhab#10701 Also save in programs cache the unuspported program Signed-off-by: Laurent Garnier <[email protected]> * Use constants OPTION_WASHER_TEMPERATURE and OPTION_WASHER_SPIN_SPEED Signed-off-by: Laurent Garnier <[email protected]> * Review comment : using constants Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Dave J Schoepel <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…asher programs (openhab#10953) * [homeconnect] Predefined temp / spin speeds options for unsupported washer programs Fix openhab#10701 Also save in programs cache the unuspported program Signed-off-by: Laurent Garnier <[email protected]> * Use constants OPTION_WASHER_TEMPERATURE and OPTION_WASHER_SPIN_SPEED Signed-off-by: Laurent Garnier <[email protected]> * Review comment : using constants Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10701
Also save in programs cache the unuspported program
Signed-off-by: Laurent Garnier [email protected]