[mielecloud] Less strict e-mail validation #10928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Lange <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/miele-cloud-binding/93266/163 |
jlaur
reviewed
Jul 6, 2021
| @NonNullByDefault | ||
| public class EmailValidatorTest { | ||
| @ParameterizedTest | ||
| @ValueSource(strings = { "[email protected]", "[email protected]", "[email protected]" }) |
There was a problem hiding this comment.
Maybe add testcases for the actual changes in this PR, for example allowing capital letters?
There was a problem hiding this comment.
I added some further test cases regarding the minimum length and uppercase letters. However, the previously already present test cases checked the style of the addresses that were reported to be problematic, namely ones that have numbers and dashes. Also capital letters are part of Java's \w shortcut Pattern syntax, so nothing should have changed in that regard in the backend validation. The frontend validation differed from that and I decided that it would be easier to understand if the regex in front- and backend would be as similar as possible and thus replaced \w.
Signed-off-by: Björn Lange <[email protected]>
BjoernLange
force-pushed
the
10927-mielecloud-less-strict-mail-validation
branch
from
a7af07f to
c1bf146
Compare
fwolter
approved these changes
Jul 17, 2021
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
* [mielecloud] Less strict e-mail validation Signed-off-by: Björn Lange <[email protected]> * Some more e-mail validation test cases Signed-off-by: Björn Lange <[email protected]> Co-authored-by: Björn Lange <[email protected]> Signed-off-by: dw-8 <[email protected]>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
This reverts commit e1df2b2.
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
* [mielecloud] Less strict e-mail validation Signed-off-by: Björn Lange <[email protected]> * Some more e-mail validation test cases Signed-off-by: Björn Lange <[email protected]> Co-authored-by: Björn Lange <[email protected]> Signed-off-by: dw-8 <[email protected]>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
This reverts commit e1df2b2. Signed-off-by: dw-8 <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* [mielecloud] Less strict e-mail validation Signed-off-by: Björn Lange <[email protected]> * Some more e-mail validation test cases Signed-off-by: Björn Lange <[email protected]> Co-authored-by: Björn Lange <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [mielecloud] Less strict e-mail validation Signed-off-by: Björn Lange <[email protected]> * Some more e-mail validation test cases Signed-off-by: Björn Lange <[email protected]> Co-authored-by: Björn Lange <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [mielecloud] Less strict e-mail validation Signed-off-by: Björn Lange <[email protected]> * Some more e-mail validation test cases Signed-off-by: Björn Lange <[email protected]> Co-authored-by: Björn Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10927.
Signed-off-by: Björn Lange [email protected]