[rfxcom] Enable Raw message transmission #10866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one ended up a little more invasive than I expected, but I think there are good enhancements to the structure. |
Jamstah
force-pushed
the
rfxcom-raw
branch
3 times, most recently
from
9ef95fd to
baa4b3e
Compare
Jamstah
added
rebuild
|
@martinvw Hesitant about this one? Let me know if you want to do a live code review at some point to discuss the approach. |
|
Rebased on latest main. |
martinvw
approved these changes
Jun 23, 2021
|
@Jamstah looks good to, is everything for lighting4 backwards compatible? |
martinvw
reviewed
Jun 23, 2021
...c/main/java/org/openhab/binding/rfxcom/internal/config/RFXComGenericDeviceConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/binding/rfxcom/internal/config/RFXComLighting4DeviceConfiguration.java
Outdated
Show resolved
Hide resolved
...m/src/main/java/org/openhab/binding/rfxcom/internal/config/RFXComRawDeviceConfiguration.java
Show resolved
Hide resolved
...com/src/main/java/org/openhab/binding/rfxcom/internal/messages/RFXComMessageFactoryImpl.java
Show resolved
Hide resolved
Yes, nothing changes for lighting4 other than it has its own device configuration class. I'm looking at lighting4 next (possibly) to try and make it more consistent for users. That will probably involve changing things up a little so that received messages can be parsed according to thing configuration parameters too. But that's for a future PR. |
Jamstah
force-pushed
the
rfxcom-raw
branch
2 times, most recently
from
7c17c44 to
baba5c7
Compare
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]>
Jamstah
added
rebuild
martinvw
approved these changes
Jun 24, 2021
martinvw
added
the
enhancement
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
This enables raw message transmission by configuring a raw thing with pulses to send for either ON, OFF, OPEN or CLOSED commands. To enable extended config, this includes a refactor for the RFXComHandler to support different Configuration objects depending on the thing type, and moves the parsing, validation, and message matching logic to the Configuration objects where the logic is more appropriate. To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted out and injected as a dependency. Signed-off-by: James Hewitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables raw message transmission by configuring a raw thing with pulses to
send for either ON, OFF, OPEN or CLOSED commands.
To enable extended config, this includes a refactor for the RFXComHandler to
support different Configuration objects depending on the thing type, and moves
the parsing, validation, and message matching logic to the Configuration objects
where the logic is more appropriate.
To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted
out and injected as a dependency.
Signed-off-by: James Hewitt [email protected]