Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openwebnet] rename thermoregulation's (WHO=4) things #10865

Merged
merged 5 commits into from
Jun 23, 2021
Merged

[openwebnet] rename thermoregulation's (WHO=4) things #10865

merged 5 commits into from
Jun 23, 2021

Conversation

aconte80
Copy link
Contributor

Renamed things used in WHO=4 Thermoregulation.

*** BREAKING CHANGE ***
bus_thermostat renamed to bus_thermo_zone
bus_temp_sensor renamed to bus_thermo_sensor

Updated openwebnet4j to 0.5.3.

Fixes #10849

aconte80 and others added 4 commits June 14, 2021 11:59
@aconte80
- bus_thermostat renamed to bus_thermo_zone
09f0dd4 
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>
@aconte80
updated ReadMe according to things renaming
7d8dcf4 
Signed-off-by: Conte Andrea <[email protected]>
@mvalla @aconte80
Updated readme and thermo thing labels. Renamed thing descriptors to …
071da6a 
…BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>
@aconte80
using own4j release 0.5.3
f8c0005 
Signed-off-by: Conte Andrea <[email protected]>
@aconte80
Copy link
Contributor Author

@fwolter this PR is just a refactoring of naming conventions of things associated to Thermoregulation: we restored support for thermoregulation in milestone 5 but, after a lot of discussions even with the community, we decide to apply this renaming.
Because it's a breaking change against what users are used to do in OH2 it would be better if we came out with the new nomenclature in OH 3.1. Do you think it's feasible?

@mvalla
Copy link
Contributor

mvalla commented Jun 19, 2021

yes @fwolter: if current (old) thermo Things naming goes to 3.1, then users will have to move to the new naming in 3.2, while if this PR is included in 3.1 they will directly use the final correct naming when they move their thermo Things to OH3.

Also: after you accept this PR, I can proceed with the refactoring to move everthing under the internal package (as you suggested), so everthing would be in place in 3,1 also from the package point of view.

fwolter
fwolter requested changes Jun 20, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this is a breaking change from 3.0 to 3.1. So you could add an ALTERT entry to https://github.com/openhab/openhab-distro/blob/main/distributions/openhab/src/main/resources/bin/update.lst.

bundles/org.openhab.binding.openwebnet/README.md Outdated
@@ -171,22 +188,22 @@ It's possible to enter a value manually or set `shutterRun=AUTO` (default) to ca

BUS gateway and things configuration:

```xtend
```json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this at all. The type doesn't need to be specified any longer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed these type tags

@mvalla
Copy link
Contributor

mvalla commented Jun 21, 2021 •
edited
Loading

If I understand correctly, this is a breaking change from 3.0 to 3.1. So you could add an ALTERT entry to https://github.com/openhab/openhab-distro/blob/main/distributions/openhab/src/main/resources/bin/update.lst.

Actually Thermo support would be introduced just now in the official openwebnet binding with 3.1: in 2.5.x or 3.0.x or 3.1Mx is not there yet.
The "breaking change" @aconte80 mentions is only in comparison to the unofficial testing version of the openwebnet binding (which works on 2.5 core).
So in my opinion, if this PR get merged into 3.1, there is no need for an official breaking change alert: we can just put it clear in the community thread that "starting from 3.1 the Thermo part is supported, but Things have a new name from the old testing binding".

@fwolter
Copy link
Member

fwolter commented Jun 21, 2021

OK, that's indeed no breaking change.

@mvalla mvalla force-pushed the dev-3.1M5-thermoThingsRefactor branch from 5616ed2 to afe92a2 Compare June 22, 2021 08:17
fwolter
fwolter approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 089a78f into openhab:main Jun 23, 2021
@fwolter fwolter added this to the 3.1 milestone Jun 23, 2021
@fwolter fwolter added the enhancement An enhancement or new feature for an existing add-on label Jun 23, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@aconte80 @mvalla @computergeek1507
[openwebnet] rename thermoregulation's (WHO=4) things (openhab#10865)
241acbc 
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>

* updated ReadMe according to things renaming

Signed-off-by: Conte Andrea <[email protected]>

* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>

* using own4j release 0.5.3

Signed-off-by: Conte Andrea <[email protected]>

* removed json tags in README. Added KG4691 to tested thermostats

Signed-off-by: Massimo Valla <[email protected]>

Co-authored-by: Massimo Valla <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@aconte80 @mvalla @lucacalcaterra
[openwebnet] rename thermoregulation's (WHO=4) things (openhab#10865)
7993799 
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>

* updated ReadMe according to things renaming

Signed-off-by: Conte Andrea <[email protected]>

* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>

* using own4j release 0.5.3

Signed-off-by: Conte Andrea <[email protected]>

* removed json tags in README. Added KG4691 to tested thermostats

Signed-off-by: Massimo Valla <[email protected]>

Co-authored-by: Massimo Valla <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@aconte80 @mvalla @lucacalcaterra
[openwebnet] rename thermoregulation's (WHO=4) things (openhab#10865)
15a9929 
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>

* updated ReadMe according to things renaming

Signed-off-by: Conte Andrea <[email protected]>

* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>

* using own4j release 0.5.3

Signed-off-by: Conte Andrea <[email protected]>

* removed json tags in README. Added KG4691 to tested thermostats

Signed-off-by: Massimo Valla <[email protected]>

Co-authored-by: Massimo Valla <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
@aconte80 @mvalla @lucacalcaterra
[openwebnet] rename thermoregulation's (WHO=4) things (openhab#10865)
54317d8 
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>

* updated ReadMe according to things renaming

Signed-off-by: Conte Andrea <[email protected]>

* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>

* using own4j release 0.5.3

Signed-off-by: Conte Andrea <[email protected]>

* removed json tags in README. Added KG4691 to tested thermostats

Signed-off-by: Massimo Valla <[email protected]>

Co-authored-by: Massimo Valla <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@aconte80 @mvalla @frederictobiasc
[openwebnet] rename thermoregulation's (WHO=4) things (openhab#10865)
60e9a17 
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>

* updated ReadMe according to things renaming

Signed-off-by: Conte Andrea <[email protected]>

* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>

* using own4j release 0.5.3

Signed-off-by: Conte Andrea <[email protected]>

* removed json tags in README. Added KG4691 to tested thermostats

Signed-off-by: Massimo Valla <[email protected]>

Co-authored-by: Massimo Valla <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@aconte80 @mvalla @thinkingstone
[openwebnet] rename thermoregulation's (WHO=4) things (openhab#10865)
0ae5460 
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>

* updated ReadMe according to things renaming

Signed-off-by: Conte Andrea <[email protected]>

* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>

* using own4j release 0.5.3

Signed-off-by: Conte Andrea <[email protected]>

* removed json tags in README. Added KG4691 to tested thermostats

Signed-off-by: Massimo Valla <[email protected]>

Co-authored-by: Massimo Valla <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@aconte80 @mvalla
[openwebnet] rename thermoregulation's (WHO=4) things (openhab#10865)
343c18d 
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)

Signed-off-by: Conte Andrea <[email protected]>

* updated ReadMe according to things renaming

Signed-off-by: Conte Andrea <[email protected]>

* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor

Signed-off-by: Massimo Valla <[email protected]>

* using own4j release 0.5.3

Signed-off-by: Conte Andrea <[email protected]>

* removed json tags in README. Added KG4691 to tested thermostats

Signed-off-by: Massimo Valla <[email protected]>

Co-authored-by: Massimo Valla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvalla mvalla mvalla left review comments

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[openwebnet] rename thermoregulation's (WHO=4) things
3 participants
@aconte80 @mvalla @fwolter