Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15) #10855

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

marcelrv
Copy link
Contributor

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
Closes #10843

Signed-off-by: Marcel Verpaalen [email protected]

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv added the enhancement An enhancement or new feature for an existing add-on label Jun 12, 2021
@marcelrv marcelrv requested a review from fwolter June 12, 2021 08:48
| alarm | Switch | Alarm - Alarm | |
| fault | Number | Motor Controller - Device Fault | Value mapping `["0"="No Faults"]` |
| physical_controls_locked | Switch | Physical Control Locked - Physical Control Locked | |
| off_delay_time | Number | Off Delay Time - Off Delay Time | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be Number:Time? Is there any reason for using underscores instead of camelCase like the other Things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codefalk can you maybe test / check in the app what is the unit for the delay time. I have no idea (e.g. seconds, minutes, hours?) e.g. by setting it in the app and see what is the response.
You can take the json file in this PR and save it in your misc/miio folder (see readme)

@fwolter the camelcase channels are made with the much older version of the conversion tooling, the newer version uses the underscore which is more in line with how Xiaomi is naming their channels.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this feature request up that quickly!

@marcelrv I checked as requested: "Off Delay Time" is in minutes. This works both ways, e.g. setting the parameter in OH as well setting the value via the Xiaomi Home App and read back in OH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great I'll change the type then.
Btw did all the other channels work fine ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, tested as much as I can:
all channels appear to work properly, However, few comments:

  • I did not test the "action" channel (since I do not know which actions are valid ones)
  • could not test the "fault" channel
  • valid values for the "mode" channel are 0 for "direct breeze" and 1 for "natural breeze"
  • valid values for the "horizontal_angle" channel are 30, 60, 90 120 and 140
  • the "status" channel seems to be read only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, first time I deal with the enhanced miio binding feature and I just realized the above information is in the json file already.
For the action channel, "off-delay-time-toggle" just switches the fan off and on depending on it's current state. Not sure why the action is named "off-delay-time-toggle" since I can not identify any relation to "off_delay_time".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem. I pushed the change to time, so I think we're good to go @fwolter

Signed-off-by: Marcel Verpaalen <[email protected]>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 8bd05c0 into openhab:main Jun 15, 2021
@fwolter fwolter added this to the 3.1 milestone Jun 15, 2021
@marcelrv marcelrv deleted the miio-dmaker-fanp15 branch June 16, 2021 12:00
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
…15) (openhab#10855)

* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>

* [miio] improve timeunit

Signed-off-by: Marcel Verpaalen <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…15) (openhab#10855)

* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>

* [miio] improve timeunit

Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…15) (openhab#10855)

* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>

* [miio] improve timeunit

Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
…15) (openhab#10855)

* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>

* [miio] improve timeunit

Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
…15) (openhab#10855)

* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>

* [miio] improve timeunit

Signed-off-by: Marcel Verpaalen <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…15) (openhab#10855)

* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>

* [miio] improve timeunit

Signed-off-by: Marcel Verpaalen <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…15) (openhab#10855)

* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)

add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close openhab#10843

Signed-off-by: Marcel Verpaalen <[email protected]>

* [miio] improve timeunit

Signed-off-by: Marcel Verpaalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miio] add Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
3 participants