-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ipcamera] Fix null URL channels and fix multiple cameras use the same ffmpeg output folder. #10846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
fwolter
requested changes
Jun 12, 2021
...ng.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/handler/IpCameraHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
All suggested changes have been made. |
Signed-off-by: Matthew Skinner <[email protected]>
fwolter
requested changes
Jun 13, 2021
...ng.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/handler/IpCameraHandler.java
Outdated
Show resolved
Hide resolved
Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Thanks for suggestions, review and catching the typo. All changes have been made. |
fwolter
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…e ffmpeg output folder. (openhab#10846) * Fix urls are null until binding restarts. Signed-off-by: Matthew Skinner <[email protected]> * Change to using port config. Signed-off-by: Matthew Skinner <[email protected]> * automate the ffmpeg output folder to follow the UID. Signed-off-by: Matthew Skinner <[email protected]> * spotless fixes. Signed-off-by: Matthew Skinner <[email protected]> * Update readme. Signed-off-by: Matthew Skinner <[email protected]> * change to using the userdata folder. Signed-off-by: Matthew Skinner <[email protected]> * change to better field description. Signed-off-by: Matthew Skinner <[email protected]> * Add advanced. Signed-off-by: Matthew Skinner <[email protected]> * Add link to docs. Signed-off-by: Matthew Skinner <[email protected]> * improve readme. Signed-off-by: Matthew Skinner <[email protected]> * improve example path in readme. Signed-off-by: Matthew Skinner <[email protected]> * Update bundles/org.openhab.binding.ipcamera/README.md Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> * Change to using ipcamera as folder loc. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
…e ffmpeg output folder. (openhab#10846) * Fix urls are null until binding restarts. Signed-off-by: Matthew Skinner <[email protected]> * Change to using port config. Signed-off-by: Matthew Skinner <[email protected]> * automate the ffmpeg output folder to follow the UID. Signed-off-by: Matthew Skinner <[email protected]> * spotless fixes. Signed-off-by: Matthew Skinner <[email protected]> * Update readme. Signed-off-by: Matthew Skinner <[email protected]> * change to using the userdata folder. Signed-off-by: Matthew Skinner <[email protected]> * change to better field description. Signed-off-by: Matthew Skinner <[email protected]> * Add advanced. Signed-off-by: Matthew Skinner <[email protected]> * Add link to docs. Signed-off-by: Matthew Skinner <[email protected]> * improve readme. Signed-off-by: Matthew Skinner <[email protected]> * improve example path in readme. Signed-off-by: Matthew Skinner <[email protected]> * Update bundles/org.openhab.binding.ipcamera/README.md Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> * Change to using ipcamera as folder loc. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
…e ffmpeg output folder. (openhab#10846) * Fix urls are null until binding restarts. Signed-off-by: Matthew Skinner <[email protected]> * Change to using port config. Signed-off-by: Matthew Skinner <[email protected]> * automate the ffmpeg output folder to follow the UID. Signed-off-by: Matthew Skinner <[email protected]> * spotless fixes. Signed-off-by: Matthew Skinner <[email protected]> * Update readme. Signed-off-by: Matthew Skinner <[email protected]> * change to using the userdata folder. Signed-off-by: Matthew Skinner <[email protected]> * change to better field description. Signed-off-by: Matthew Skinner <[email protected]> * Add advanced. Signed-off-by: Matthew Skinner <[email protected]> * Add link to docs. Signed-off-by: Matthew Skinner <[email protected]> * improve readme. Signed-off-by: Matthew Skinner <[email protected]> * improve example path in readme. Signed-off-by: Matthew Skinner <[email protected]> * Update bundles/org.openhab.binding.ipcamera/README.md Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> * Change to using ipcamera as folder loc. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
…e ffmpeg output folder. (openhab#10846) * Fix urls are null until binding restarts. Signed-off-by: Matthew Skinner <[email protected]> * Change to using port config. Signed-off-by: Matthew Skinner <[email protected]> * automate the ffmpeg output folder to follow the UID. Signed-off-by: Matthew Skinner <[email protected]> * spotless fixes. Signed-off-by: Matthew Skinner <[email protected]> * Update readme. Signed-off-by: Matthew Skinner <[email protected]> * change to using the userdata folder. Signed-off-by: Matthew Skinner <[email protected]> * change to better field description. Signed-off-by: Matthew Skinner <[email protected]> * Add advanced. Signed-off-by: Matthew Skinner <[email protected]> * Add link to docs. Signed-off-by: Matthew Skinner <[email protected]> * improve readme. Signed-off-by: Matthew Skinner <[email protected]> * improve example path in readme. Signed-off-by: Matthew Skinner <[email protected]> * Update bundles/org.openhab.binding.ipcamera/README.md Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> * Change to using ipcamera as folder loc. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…e ffmpeg output folder. (openhab#10846) * Fix urls are null until binding restarts. Signed-off-by: Matthew Skinner <[email protected]> * Change to using port config. Signed-off-by: Matthew Skinner <[email protected]> * automate the ffmpeg output folder to follow the UID. Signed-off-by: Matthew Skinner <[email protected]> * spotless fixes. Signed-off-by: Matthew Skinner <[email protected]> * Update readme. Signed-off-by: Matthew Skinner <[email protected]> * change to using the userdata folder. Signed-off-by: Matthew Skinner <[email protected]> * change to better field description. Signed-off-by: Matthew Skinner <[email protected]> * Add advanced. Signed-off-by: Matthew Skinner <[email protected]> * Add link to docs. Signed-off-by: Matthew Skinner <[email protected]> * improve readme. Signed-off-by: Matthew Skinner <[email protected]> * improve example path in readme. Signed-off-by: Matthew Skinner <[email protected]> * Update bundles/org.openhab.binding.ipcamera/README.md Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> * Change to using ipcamera as folder loc. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…e ffmpeg output folder. (openhab#10846) * Fix urls are null until binding restarts. Signed-off-by: Matthew Skinner <[email protected]> * Change to using port config. Signed-off-by: Matthew Skinner <[email protected]> * automate the ffmpeg output folder to follow the UID. Signed-off-by: Matthew Skinner <[email protected]> * spotless fixes. Signed-off-by: Matthew Skinner <[email protected]> * Update readme. Signed-off-by: Matthew Skinner <[email protected]> * change to using the userdata folder. Signed-off-by: Matthew Skinner <[email protected]> * change to better field description. Signed-off-by: Matthew Skinner <[email protected]> * Add advanced. Signed-off-by: Matthew Skinner <[email protected]> * Add link to docs. Signed-off-by: Matthew Skinner <[email protected]> * improve readme. Signed-off-by: Matthew Skinner <[email protected]> * improve example path in readme. Signed-off-by: Matthew Skinner <[email protected]> * Update bundles/org.openhab.binding.ipcamera/README.md Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> * Change to using ipcamera as folder loc. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…e ffmpeg output folder. (openhab#10846) * Fix urls are null until binding restarts. Signed-off-by: Matthew Skinner <[email protected]> * Change to using port config. Signed-off-by: Matthew Skinner <[email protected]> * automate the ffmpeg output folder to follow the UID. Signed-off-by: Matthew Skinner <[email protected]> * spotless fixes. Signed-off-by: Matthew Skinner <[email protected]> * Update readme. Signed-off-by: Matthew Skinner <[email protected]> * change to using the userdata folder. Signed-off-by: Matthew Skinner <[email protected]> * change to better field description. Signed-off-by: Matthew Skinner <[email protected]> * Add advanced. Signed-off-by: Matthew Skinner <[email protected]> * Add link to docs. Signed-off-by: Matthew Skinner <[email protected]> * improve readme. Signed-off-by: Matthew Skinner <[email protected]> * improve example path in readme. Signed-off-by: Matthew Skinner <[email protected]> * Update bundles/org.openhab.binding.ipcamera/README.md Cut and paste bandit strikes again. thanks. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> * Change to using ipcamera as folder loc. Signed-off-by: Matthew Skinner <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues:
Some refactoring was also done to reduce some newly added code analysis warnings.
Precompiled jar can be found here:
http://pcmus.com/openhab/IpCameraBinding/
Signed-off-by: Matthew Skinner [email protected]