Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera] Fix null URL channels and fix multiple cameras use the same ffmpeg output folder. #10846

Merged
merged 13 commits into from
Jun 15, 2021

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Jun 10, 2021

Fixes two issues:

  1. Bug catches a number of users where the camera thing comes ONLINE and then they create and link items for the url channels. The channels stayed null until the binding was restarted, or a config of the thing was changed. This fix now updates the channels when it detects they link to an item to these channels. Making this change should reduce new user frustration and would be good to get this into the next stable build.
  2. Issue 10661 reported by a user raises that if someone does not edit the default ffmpegOutput path, multiple cameras can then use the same folder and create issues. Fix works by using the UID to ensure the path is unique and can be set to a friendly name automatically with the UID when the thing is created.

Some refactoring was also done to reduce some newly added code analysis warnings.

Precompiled jar can be found here:
http://pcmus.com/openhab/IpCameraBinding/

Signed-off-by: Matthew Skinner [email protected]

@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Jun 10, 2021
@Skinah Skinah linked an issue Jun 12, 2021 that may be closed by this pull request
@Skinah Skinah changed the title [ipcamera] Fix url channels null until binding or thing restarts. [ipcamera] Fix null URL channels and fix multiple cameras use the same ffmpeg output folder. Jun 12, 2021
Skinah added 2 commits June 12, 2021 18:13
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Skinah added 5 commits June 13, 2021 14:00
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
@Skinah
Copy link
Contributor Author

Skinah commented Jun 13, 2021

All suggested changes have been made.

Signed-off-by: Matthew Skinner <[email protected]>
Skinah and others added 2 commits June 13, 2021 23:59
Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
@Skinah
Copy link
Contributor Author

Skinah commented Jun 13, 2021

Thanks for suggestions, review and catching the typo. All changes have been made.

@Skinah Skinah added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 14, 2021
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit f263c13 into openhab:main Jun 15, 2021
@fwolter fwolter added this to the 3.1 milestone Jun 15, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
…e ffmpeg output folder. (openhab#10846)

* Fix urls are null until binding restarts.


Signed-off-by: Matthew Skinner <[email protected]>

* Change to using port config.


Signed-off-by: Matthew Skinner <[email protected]>

* automate the ffmpeg output folder to follow the UID.


Signed-off-by: Matthew Skinner <[email protected]>

* spotless fixes.


Signed-off-by: Matthew Skinner <[email protected]>

* Update readme.


Signed-off-by: Matthew Skinner <[email protected]>

* change to using the userdata folder.


Signed-off-by: Matthew Skinner <[email protected]>

* change to better field description.


Signed-off-by: Matthew Skinner <[email protected]>

* Add advanced.


Signed-off-by: Matthew Skinner <[email protected]>

* Add link to docs.


Signed-off-by: Matthew Skinner <[email protected]>

* improve readme.

Signed-off-by: Matthew Skinner <[email protected]>

* improve example path in readme.


Signed-off-by: Matthew Skinner <[email protected]>

* Update bundles/org.openhab.binding.ipcamera/README.md

Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>

* Change to using ipcamera as folder loc.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…e ffmpeg output folder. (openhab#10846)

* Fix urls are null until binding restarts.

Signed-off-by: Matthew Skinner <[email protected]>

* Change to using port config.

Signed-off-by: Matthew Skinner <[email protected]>

* automate the ffmpeg output folder to follow the UID.

Signed-off-by: Matthew Skinner <[email protected]>

* spotless fixes.

Signed-off-by: Matthew Skinner <[email protected]>

* Update readme.

Signed-off-by: Matthew Skinner <[email protected]>

* change to using the userdata folder.

Signed-off-by: Matthew Skinner <[email protected]>

* change to better field description.

Signed-off-by: Matthew Skinner <[email protected]>

* Add advanced.

Signed-off-by: Matthew Skinner <[email protected]>

* Add link to docs.

Signed-off-by: Matthew Skinner <[email protected]>

* improve readme.

Signed-off-by: Matthew Skinner <[email protected]>

* improve example path in readme.

Signed-off-by: Matthew Skinner <[email protected]>

* Update bundles/org.openhab.binding.ipcamera/README.md

Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>

* Change to using ipcamera as folder loc.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…e ffmpeg output folder. (openhab#10846)

* Fix urls are null until binding restarts.

Signed-off-by: Matthew Skinner <[email protected]>

* Change to using port config.

Signed-off-by: Matthew Skinner <[email protected]>

* automate the ffmpeg output folder to follow the UID.

Signed-off-by: Matthew Skinner <[email protected]>

* spotless fixes.

Signed-off-by: Matthew Skinner <[email protected]>

* Update readme.

Signed-off-by: Matthew Skinner <[email protected]>

* change to using the userdata folder.

Signed-off-by: Matthew Skinner <[email protected]>

* change to better field description.

Signed-off-by: Matthew Skinner <[email protected]>

* Add advanced.

Signed-off-by: Matthew Skinner <[email protected]>

* Add link to docs.

Signed-off-by: Matthew Skinner <[email protected]>

* improve readme.

Signed-off-by: Matthew Skinner <[email protected]>

* improve example path in readme.

Signed-off-by: Matthew Skinner <[email protected]>

* Update bundles/org.openhab.binding.ipcamera/README.md

Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>

* Change to using ipcamera as folder loc.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
…e ffmpeg output folder. (openhab#10846)

* Fix urls are null until binding restarts.

Signed-off-by: Matthew Skinner <[email protected]>

* Change to using port config.

Signed-off-by: Matthew Skinner <[email protected]>

* automate the ffmpeg output folder to follow the UID.

Signed-off-by: Matthew Skinner <[email protected]>

* spotless fixes.

Signed-off-by: Matthew Skinner <[email protected]>

* Update readme.

Signed-off-by: Matthew Skinner <[email protected]>

* change to using the userdata folder.

Signed-off-by: Matthew Skinner <[email protected]>

* change to better field description.

Signed-off-by: Matthew Skinner <[email protected]>

* Add advanced.

Signed-off-by: Matthew Skinner <[email protected]>

* Add link to docs.

Signed-off-by: Matthew Skinner <[email protected]>

* improve readme.

Signed-off-by: Matthew Skinner <[email protected]>

* improve example path in readme.

Signed-off-by: Matthew Skinner <[email protected]>

* Update bundles/org.openhab.binding.ipcamera/README.md

Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>

* Change to using ipcamera as folder loc.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
…e ffmpeg output folder. (openhab#10846)

* Fix urls are null until binding restarts.


Signed-off-by: Matthew Skinner <[email protected]>

* Change to using port config.


Signed-off-by: Matthew Skinner <[email protected]>

* automate the ffmpeg output folder to follow the UID.


Signed-off-by: Matthew Skinner <[email protected]>

* spotless fixes.


Signed-off-by: Matthew Skinner <[email protected]>

* Update readme.


Signed-off-by: Matthew Skinner <[email protected]>

* change to using the userdata folder.


Signed-off-by: Matthew Skinner <[email protected]>

* change to better field description.


Signed-off-by: Matthew Skinner <[email protected]>

* Add advanced.


Signed-off-by: Matthew Skinner <[email protected]>

* Add link to docs.


Signed-off-by: Matthew Skinner <[email protected]>

* improve readme.

Signed-off-by: Matthew Skinner <[email protected]>

* improve example path in readme.


Signed-off-by: Matthew Skinner <[email protected]>

* Update bundles/org.openhab.binding.ipcamera/README.md

Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>

* Change to using ipcamera as folder loc.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…e ffmpeg output folder. (openhab#10846)

* Fix urls are null until binding restarts.


Signed-off-by: Matthew Skinner <[email protected]>

* Change to using port config.


Signed-off-by: Matthew Skinner <[email protected]>

* automate the ffmpeg output folder to follow the UID.


Signed-off-by: Matthew Skinner <[email protected]>

* spotless fixes.


Signed-off-by: Matthew Skinner <[email protected]>

* Update readme.


Signed-off-by: Matthew Skinner <[email protected]>

* change to using the userdata folder.


Signed-off-by: Matthew Skinner <[email protected]>

* change to better field description.


Signed-off-by: Matthew Skinner <[email protected]>

* Add advanced.


Signed-off-by: Matthew Skinner <[email protected]>

* Add link to docs.


Signed-off-by: Matthew Skinner <[email protected]>

* improve readme.

Signed-off-by: Matthew Skinner <[email protected]>

* improve example path in readme.


Signed-off-by: Matthew Skinner <[email protected]>

* Update bundles/org.openhab.binding.ipcamera/README.md

Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>

* Change to using ipcamera as folder loc.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…e ffmpeg output folder. (openhab#10846)

* Fix urls are null until binding restarts.


Signed-off-by: Matthew Skinner <[email protected]>

* Change to using port config.


Signed-off-by: Matthew Skinner <[email protected]>

* automate the ffmpeg output folder to follow the UID.


Signed-off-by: Matthew Skinner <[email protected]>

* spotless fixes.


Signed-off-by: Matthew Skinner <[email protected]>

* Update readme.


Signed-off-by: Matthew Skinner <[email protected]>

* change to using the userdata folder.


Signed-off-by: Matthew Skinner <[email protected]>

* change to better field description.


Signed-off-by: Matthew Skinner <[email protected]>

* Add advanced.


Signed-off-by: Matthew Skinner <[email protected]>

* Add link to docs.


Signed-off-by: Matthew Skinner <[email protected]>

* improve readme.

Signed-off-by: Matthew Skinner <[email protected]>

* improve example path in readme.


Signed-off-by: Matthew Skinner <[email protected]>

* Update bundles/org.openhab.binding.ipcamera/README.md

Cut and paste bandit strikes again. thanks.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>

* Change to using ipcamera as folder loc.

Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IpCamera] FFmpeg Output Folder overwriting issue
2 participants