Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deconz] Set "ontime" option only if thing has got an ONTIME channel #10829

Merged
merged 2 commits into from
Jun 14, 2021
Merged

[deconz] Set "ontime" option only if thing has got an ONTIME channel #10829

merged 2 commits into from
Jun 14, 2021

Conversation

MHerbst
Copy link
Contributor

@MHerbst MHerbst commented Jun 8, 2021

This PR corrects a problem (#10774) in the binding that currently makes it unusable for window coverings because no reall bypass exists.

@MHerbst MHerbst requested a review from a team as a code owner June 8, 2021 17:58
@J-N-K
Copy link
Member

J-N-K commented Jun 8, 2021

Another solution is changing the ontime field to Integer and initialize it with null. Without ontime-channel it always stays null, and the DTO‘s field is Never serialized.

No need to change other code then.

@MHerbst
Copy link
Contributor Author

MHerbst commented Jun 12, 2021

No need to change other code then.

Yes, you are right. This is really a simpler solution.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp linked an issue Jun 14, 2021 that may be closed by this pull request
@cweitkamp cweitkamp added this to the 3.1 milestone Jun 14, 2021
@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of an add-on label Jun 14, 2021
@cweitkamp cweitkamp merged commit 82dba8d into openhab:main Jun 14, 2021
@MHerbst MHerbst deleted the issue-10774 branch July 3, 2021 17:14
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
…penhab#10829)

* Set "ontime" option only if thing has got an ONTIME channel

Fixes openhab#10774

Signed-off-by: Martin Herbst <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…penhab#10829)

* Set "ontime" option only if thing has got an ONTIME channel

Fixes openhab#10774

Signed-off-by: Martin Herbst <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…penhab#10829)

* Set "ontime" option only if thing has got an ONTIME channel

Fixes openhab#10774

Signed-off-by: Martin Herbst <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
…penhab#10829)

* Set "ontime" option only if thing has got an ONTIME channel

Fixes openhab#10774

Signed-off-by: Martin Herbst <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
…penhab#10829)

* Set "ontime" option only if thing has got an ONTIME channel

Fixes openhab#10774

Signed-off-by: Martin Herbst <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…penhab#10829)

* Set "ontime" option only if thing has got an ONTIME channel

Fixes openhab#10774

Signed-off-by: Martin Herbst <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…penhab#10829)

* Set "ontime" option only if thing has got an ONTIME channel

Fixes openhab#10774

Signed-off-by: Martin Herbst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deCONZ] Window Covering not working
3 participants