-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deconz] Set "ontime" option only if thing has got an ONTIME channel #10829
Conversation
Another solution is changing the No need to change other code then. |
Fixes #10774 Signed-off-by: Martin Herbst <[email protected]>
Signed-off-by: Martin Herbst <[email protected]>
Yes, you are right. This is really a simpler solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
…penhab#10829) * Set "ontime" option only if thing has got an ONTIME channel Fixes openhab#10774 Signed-off-by: Martin Herbst <[email protected]>
…penhab#10829) * Set "ontime" option only if thing has got an ONTIME channel Fixes openhab#10774 Signed-off-by: Martin Herbst <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
…penhab#10829) * Set "ontime" option only if thing has got an ONTIME channel Fixes openhab#10774 Signed-off-by: Martin Herbst <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
…penhab#10829) * Set "ontime" option only if thing has got an ONTIME channel Fixes openhab#10774 Signed-off-by: Martin Herbst <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
…penhab#10829) * Set "ontime" option only if thing has got an ONTIME channel Fixes openhab#10774 Signed-off-by: Martin Herbst <[email protected]>
…penhab#10829) * Set "ontime" option only if thing has got an ONTIME channel Fixes openhab#10774 Signed-off-by: Martin Herbst <[email protected]>
…penhab#10829) * Set "ontime" option only if thing has got an ONTIME channel Fixes openhab#10774 Signed-off-by: Martin Herbst <[email protected]>
This PR corrects a problem (#10774) in the binding that currently makes it unusable for window coverings because no reall bypass exists.