[nikobus] removed required=true for parameters with default value #10795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Krivonog [email protected] Signed-off-by: Boris Krivonog <[email protected]>
crnjan
force-pushed
the
bugfix/remove_required_for_par_with_default
branch
from
fc52b43 to
f8ca758
Compare
kaikreuzer
approved these changes
Jun 5, 2021
kaikreuzer
added
bug
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Boris Krivonog <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
Signed-off-by: Boris Krivonog <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
Signed-off-by: Boris Krivonog <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
Signed-off-by: Boris Krivonog <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
Signed-off-by: Boris Krivonog <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Boris Krivonog <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Boris Krivonog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from some users it seems
required=trueshould not be set for parameters that have a default value, as stated here, otherwise one can have problems when restarting OH.Signed-off-by: Boris Krivonog [email protected]