Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smhi] Catch exception that could cause binding to stop updating channels #10794

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

pacive
Copy link
Member

@pacive pacive commented Jun 2, 2021

Signed-off-by: Anders Alfredsson [email protected]

Discovered an issue where the binding would crash and stop updating if there was something wrong in the json received from the api. This fix catches these exceptions and sets the thing temporarily OFFLINE until a valid response is received.

@pacive pacive changed the title Catch exception that could cause binding to stop updating channels [smhi] Catch exception that could cause binding to stop updating channels Jun 2, 2021
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 5, 2021
@fwolter fwolter merged commit d454fe3 into openhab:main Jun 5, 2021
@fwolter fwolter added this to the 3.1 milestone Jun 5, 2021
@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Jun 5, 2021
@pacive pacive deleted the smhi-fix branch June 5, 2021 17:47
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants