-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kostalinverter] Added new channels frequency and cosphi #10779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61e1679
to
db1263e
Compare
|
68233cf
to
981e78f
Compare
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]>
fwolter
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@cschneider As the code owner, please raise your hand if you think this shouldn't have been merged for some reason.
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]> Co-authored-by: Martin Hubert <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]> Co-authored-by: Martin Hubert <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]> Co-authored-by: Martin Hubert <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]> Co-authored-by: Martin Hubert <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]> Co-authored-by: Martin Hubert <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]> Co-authored-by: Martin Hubert <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
new channels frequency and power factor. Signed-off-by: Martin Hubert <[email protected]> Co-authored-by: Martin Hubert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the new channels (AC) frequency and cosphi to third generation inverters.
Tested with my Kostal Plenticore plus 10 with battery.