Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kostalinverter] Added new channels frequency and cosphi #10779

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

martin-hu
Copy link
Contributor

This pull request adds the new channels (AC) frequency and cosphi to third generation inverters.

Tested with my Kostal Plenticore plus 10 with battery.

@martin-hu martin-hu requested a review from cschneider as a code owner May 30, 2021 19:47
@martin-hu martin-hu force-pushed the kostal branch 2 times, most recently from 61e1679 to db1263e Compare May 30, 2021 19:55
@martin-hu
Copy link
Contributor Author

Build timed out (after 240 minutes). Marking the build as aborted.

@martin-hu martin-hu force-pushed the kostal branch 2 times, most recently from 68233cf to 981e78f Compare June 1, 2021 05:10
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cschneider As the code owner, please raise your hand if you think this shouldn't have been merged for some reason.

@fwolter fwolter merged commit 7c5f60d into openhab:main Jun 5, 2021
@fwolter fwolter added this to the 3.1 milestone Jun 5, 2021
@fwolter fwolter added the enhancement An enhancement or new feature for an existing add-on label Jun 5, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>

Co-authored-by: Martin Hubert <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>

Co-authored-by: Martin Hubert <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>

Co-authored-by: Martin Hubert <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>

Co-authored-by: Martin Hubert <[email protected]>
Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>

Co-authored-by: Martin Hubert <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>

Co-authored-by: Martin Hubert <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
new channels frequency and power factor.

Signed-off-by: Martin Hubert <[email protected]>

Co-authored-by: Martin Hubert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants