[openwebnet] add support for Thermoregulation (standalone thermostat and sensors) #10756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fwolter, do you think it's possibile to include this in 3.1M5 ? This is an important and long-awaited enhancement and surely users will need to test it before merging in the upcoming 3.1 (expected in June). If we skip merge of this PR to the June milestone, that would mean that it would be integrated in the official 3.1 without much testing by users. Of course we already tested it as much as possibile in our 2 setups, but having feedback from community would be impotant. Thanks! |
fwolter
requested changes
May 26, 2021
...ding.openwebnet/src/main/java/org/openhab/binding/openwebnet/OpenWebNetBindingConstants.java
Outdated
Show resolved
Hide resolved
...ding.openwebnet/src/main/java/org/openhab/binding/openwebnet/OpenWebNetBindingConstants.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusTempSensor.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
|
@fwolter The jenkins build failed but not our fault. Should we do something? |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/bticino-openwebnet-new-openhab2-binding-ready-for-testing/43377/1538 |
… 0.5-shapshot) - [Thermo] new fanspeed channel to control fancoil speed (AUTO, VEL1/2/3) - [Thermo] support for mode (MANUAL, PROTECTION, OFF) and function (HEATING, COOLING, GENERIC) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]>
- add channel heatingValve - removed unused code and comments - replaced bridgeHandler.gateway.send() with this.send() --> better check for null Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]>
- added requestActuatorStatus() inside initialize() and bridgeStatusUpdate() Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]>
Updated conditioning/heatingValve and actutor channels values to strings. Updated and cleaned-up README Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Conte Andrea <[email protected]>
- added tests for WhereThermo and OwnId Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Conte Andrea <[email protected]>
…orum hint to actuator/valve status Signed-off-by: Conte Andrea <[email protected]>
Signed-off-by: Conte Andrea <[email protected]>
…ed handleSetpoint and handleSetFanSpeed Signed-off-by: Massimo Valla <[email protected]>
aconte80
force-pushed
the
dev-3.1M4-thermo
branch
from
64290b9 to
57a851a
Compare
kaikreuzer
added
rebuild
fwolter
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
LGTM
Could you or @mvalla fix this SAT finding in a follow-up PR?
[WARNING] org.openhab.binding.openwebnet.handler.OpenWebNetEnergyHandler.java:[101]
For periodically executed jobs that do not require a fixed rate scheduleWithFixedDelay should be preferred over scheduleAtFixedRate.
fwolter
added
the
enhancement
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]> Co-authored-by: Massimo Valla <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]> Co-authored-by: Massimo Valla <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]> Co-authored-by: Massimo Valla <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]> Co-authored-by: Massimo Valla <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]> Co-authored-by: Massimo Valla <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]> Co-authored-by: Massimo Valla <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <[email protected]> Signed-off-by: Massimo Valla <[email protected]> Co-authored-by: Massimo Valla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement restores support for Thermoregulation for standalone thermostat (bus_thermostat) and external wireless temperature sensors (bus_temp_sensor).
Fixes #10702
Fixes #8582