[senechome] Extend with additional channels, refactor and various improvements #10687

eguib · 2021-05-13T20:21:27Z

As I got a new "SENEC.Home V3 hybrid duo" some months ago I started playing around with OpenHab and here is the result. I added a lot of additional channels, esp. because I wanted to monitor the MPP values (as in my situation MPP1 and MPP3 have the same number of solar panel, but sometimes quite different solar production ...).
Also added wallbox monitoring as Senec itself does not provide any historic data regarding the wallbox (except the current day values there is no data available at all).

While working with the code I refactored SenecHomeHandler in a similar way as @KorbinianP with PR #9535 (with some additional nice functionality to handle different scaling of the data). Also "merged" the renaming of batteryState to systemState as the new name reflects the correct meaning of the channel. Also did this because merge of the 2 PR will result in merge conflicts due the refactring done on both branches. With the approval of the author this PR could become a replacement/enhancement for #9535.

I also hit the senec error described with issue #10025. I catched the parent exception JsonParseException because I have seen different "strange" malformed/broken communications resulting in both JsonIOException and JsonSyntaxException.
=> with this error handling the binding run "stable" for several weeks.

I attach my snapshot build, would be interesting to test it with other Senec variants (V2, V3 ...) I tried to code as defensive as possible, but it is not clear to me how the different senec machines will react ...
One must consider the following:

currently there is a bug in the snapshot build regarding decimal separator, see [rfxcom] Intermittent issues receiving data for Owl USB CM160 Energy meter #2360. To see "correct" values use e.g. en_US locale
due to Upgrade Units of Measurement dependencies #10583 the attached jar does not work with older openhab versions (e.g. 3.1.0.Mx) as the OSGI dependency requirement are not fulfilled

Looking forward to some feedback. Please be gracious, it is my first contribution ;-)

org.openhab.binding.senechome-3.1.0-SNAPSHOT.jar.zip

Fixes #10679

…handling (openhab#10679). Merged PR 9535 (rename batteryState to system state) - charge/discharge energy/current/voltage/min/maxCellVoltage/load cycles per battery pack - current/power/voltage per MPP - liveHouseConsumption/livePowerGenerator - battery,case,MCU temperature - wallbox1: state, charging power/current, liveEnergy - improve error handling, catch malformed JSON exception to prevent crashing the binding - merged PR: 9535 (rename batteryState to systemState) - renamed SenecHomeLimitation to SenecHomePower and added more channels - refactored SenecHomeHandler to reduce code duplication (added some nice helper methods) Signed-off-by: Erwin Guib <[email protected]>

Signed-off-by: Erwin Guib <[email protected]>

…"real" testdata from "vars.html" Adjusted SenecHomeHandler#getSenecValue to support the full value range (int value parsing) Signed-off-by: Erwin Guib <[email protected]>

KorbinianP · 2021-05-17T05:18:49Z

Hello @eguib

Thank you so much for your contribution! So many more data points 😊

I will have a closer look into the code, but looking into my work week I can't promise a quick response. A quick overview looks really nice!

Do you want to add yourself as code owner? I would be happy 👍

KorbinianP

I really like your changes. Would you like to add yourself as code owner?

KorbinianP · 2021-05-22T11:22:16Z

...binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandler.java

@@ -12,6 +12,7 @@
 */
 package org.openhab.binding.senechome.internal;

+import static org.openhab.binding.senechome.internal.SenecHomeBindingConstants.*;


Very nice! Easy way to improve readability below 👍

KorbinianP · 2021-05-22T11:24:36Z

...binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandler.java

+    protected <Q extends Quantity<Q>> void updateQtyState(String channelName, String senecValue, int scale,
+            Unit<Q> unit) {
+        updateQtyState(channelName, senecValue, scale, unit, null);
+    }
+
+    protected <Q extends Quantity<Q>> void updateQtyState(String channelName, String senecValue, int scale,
+            Unit<Q> unit, @Nullable BigDecimal divisor) {
+        Channel channel = getThing().getChannel(channelName);
+        if (channel == null) {
+            return;
+        }
+        BigDecimal value = getSenecValue(senecValue);
+        if (divisor != null) {
+            value = value.divide(divisor, scale, RoundingMode.HALF_UP);
+        } else {
+            value = value.setScale(scale, RoundingMode.HALF_UP);
+        }
+        updateState(channel.getUID(), new QuantityType<Q>(value, unit));
+    }


KorbinianP · 2021-05-22T11:25:17Z

...binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandler.java

-            updateState(channelGridPower.getUID(), new QuantityType<Power>(gridTotal, Units.WATT));
+            updateState(channelGridPower.getUID(), new QuantityType<>(gridTotal, Units.WATT));


Why was the removed?

Java type inference: the compiler can "gues" the correct type from generics definition (because WATT is defined as Unit<Power>).
This "feature" is also used on the various "updateQtyState" methods I introduced. The QuantityType infers its generic type from the "unit".

Signed-off-by: Erwin Guib <[email protected]>

kaikreuzer

lgtm, thank you!

…actor and various improvements (openhab#10687) * [senechome] Extend with additional channels; refactor; improve error handling (openhab#10679). Merged PR 9535 (rename batteryState to system state) - charge/discharge energy/current/voltage/min/maxCellVoltage/load cycles per battery pack - current/power/voltage per MPP - liveHouseConsumption/livePowerGenerator - battery,case,MCU temperature - wallbox1: state, charging power/current, liveEnergy - improve error handling, catch malformed JSON exception to prevent crashing the binding - merged PR: 9535 (rename batteryState to systemState) - renamed SenecHomeLimitation to SenecHomePower and added more channels - refactored SenecHomeHandler to reduce code duplication (added some nice helper methods) Signed-off-by: Erwin Guib <[email protected]>

eguib force-pushed the 10679_senechome_new_channels branch from f30a6fc to 8cb6f4e Compare May 13, 2021 20:45

eguib added 2 commits May 14, 2021 19:53

[senechome] (openhab#10679) some more javadoc

6e43c82

Signed-off-by: Erwin Guib <[email protected]>

[senechome] (openhab#10679) added test for senec value parsing using …

f20a473

…"real" testdata from "vars.html" Adjusted SenecHomeHandler#getSenecValue to support the full value range (int value parsing) Signed-off-by: Erwin Guib <[email protected]>

KorbinianP approved these changes May 22, 2021

View reviewed changes

eguib added 2 commits May 22, 2021 22:21

Merge branch 'main' into 10679_senechome_new_channels

b9e58ad

[senechome] (openhab#10679) added myself to CODEOWNERS for senechome

96352d7

Signed-off-by: Erwin Guib <[email protected]>

eguib requested a review from a team as a code owner May 22, 2021 20:41

Merge branch 'main' into 10679_senechome_new_channels

6f3377b

kaikreuzer approved these changes May 29, 2021

View reviewed changes

kaikreuzer merged commit 3875d2a into openhab:main May 29, 2021

kaikreuzer added this to the 3.1 milestone May 29, 2021

kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label May 29, 2021

wborn changed the title ~~[senechome] issue #10679: Extend with additional channels; refactor and various improvements~~ [senechome] Extend with additional channels, refactor and various improvements Jun 22, 2021

Skinah mentioned this pull request Oct 2, 2021

[senechome] code cleanup and rename of battery state to system state #9535

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[senechome] Extend with additional channels, refactor and various improvements #10687

[senechome] Extend with additional channels, refactor and various improvements #10687

eguib commented May 13, 2021 •

edited by wborn

Loading

KorbinianP commented May 17, 2021

KorbinianP left a comment

KorbinianP May 22, 2021

KorbinianP May 22, 2021

KorbinianP May 22, 2021

eguib May 22, 2021 •

edited

Loading

kaikreuzer left a comment

		updateState(channelGridPower.getUID(), new QuantityType<Power>(gridTotal, Units.WATT));
		updateState(channelGridPower.getUID(), new QuantityType<>(gridTotal, Units.WATT));

[senechome] Extend with additional channels, refactor and various improvements #10687

[senechome] Extend with additional channels, refactor and various improvements #10687

Conversation

eguib commented May 13, 2021 • edited by wborn Loading

KorbinianP commented May 17, 2021

KorbinianP left a comment

Choose a reason for hiding this comment

KorbinianP May 22, 2021

Choose a reason for hiding this comment

KorbinianP May 22, 2021

Choose a reason for hiding this comment

KorbinianP May 22, 2021

Choose a reason for hiding this comment

eguib May 22, 2021 • edited Loading

Choose a reason for hiding this comment

kaikreuzer left a comment

Choose a reason for hiding this comment

eguib commented May 13, 2021 •

edited by wborn

Loading

eguib May 22, 2021 •

edited

Loading