Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luftdateninfo] Add internal sensor support #10643

Merged
merged 7 commits into from
May 13, 2021
Merged

[luftdateninfo] Add internal sensor support #10643

merged 7 commits into from
May 13, 2021

Conversation

weymann
Copy link
Contributor

@weymann weymann commented May 3, 2021

Adding new config parameter "IP Address" to enable access to sensors in local network without accessing the cloud servers from the sensor community.
Fixes #10641.

@Skinah Skinah added the enhancement An enhancement or new feature for an existing add-on label May 5, 2021
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 7, 2021
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give this PR a bit more reasonable title? It will appear in the changelog.

@@ -21,10 +19,21 @@ There's no auto discovery. See Thing configuration how to setup a Sensor.

## Thing Configuration

Choose either a local IP address of your personal owned sonsor _or_ a sensor id of an external one.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Choose either a local IP address of your personal owned sonsor _or_ a sensor id of an external one.
Choose either a local IP address of your personal owned sensor _or_ a sensor id of an external one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@weymann weymann changed the title [luftdateninfo] internal sensor config [luftdateninfo] Add internal sensor support May 11, 2021
Signed-off-by: Bernd Weymann <[email protected]>
@weymann weymann requested a review from fwolter May 12, 2021 15:57
@fwolter fwolter added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 13, 2021
@fwolter fwolter merged commit bafa841 into openhab:main May 13, 2021
@fwolter fwolter added this to the 3.1 milestone May 13, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[luftdateninfo] internal sensor support
4 participants