Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[avmfritz] Correct spelling error and add new device to list of tested devices #10593

Merged
merged 1 commit into from
Apr 27, 2021
Merged

[avmfritz] Correct spelling error and add new device to list of tested devices #10593

merged 1 commit into from
Apr 27, 2021

Conversation

quidam
Copy link
Contributor

@quidam quidam commented Apr 26, 2021

This PR corrects a spelling error in the German translation (Rolladen with 2 instead of 3 l's) and adds the Becker BoxCTRL roller shutter drive to the list of tested devices.

There are no functional changes in this PR, just text changes.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 26, 2021
@quidam
Copy link
Contributor Author

quidam commented Apr 27, 2021

@cweitkamp Thanks for approving my PR. As far as I can see, the Jenkins build failure was caused by the PLCLogo addon and has nothing to do with my changes. How can I restart the build?
And, do you know if anybody is working on the cause of the failure? Since yesterday afternoon (Build #3876) all builds fail with the error "Could not find artifact org.openhab.binding.plclogo:Moka7:jar:1.0.2-iopatch in openhab-release".

@cweitkamp
Copy link
Contributor

You are able to restart a build by adding the rebuild label to your PRs. This will trigger Jenkins.

As you changed just documentation boats I do not see a reason why the build failure should be related. I will merge this now. Thanks again.

@cweitkamp cweitkamp merged commit 9a0ad98 into openhab:main Apr 27, 2021
@quidam quidam deleted the 10430-becker-motor branch April 28, 2021 05:23
@wborn wborn added this to the 3.1 milestone Apr 28, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…on for Becker BoxCTRL (openhab#10593)

- Corrected typo in German translation and added documentation for Becker BoxCTRL

Signed-off-by: Ulrich Mertin <[email protected]>
Signed-off-by: John Marshall <[email protected]>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
…on for Becker BoxCTRL (openhab#10593)

- Corrected typo in German translation and added documentation for Becker BoxCTRL

Signed-off-by: Ulrich Mertin <[email protected]>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
…on for Becker BoxCTRL (openhab#10593)

- Corrected typo in German translation and added documentation for Becker BoxCTRL

Signed-off-by: Ulrich Mertin <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…on for Becker BoxCTRL (openhab#10593)

- Corrected typo in German translation and added documentation for Becker BoxCTRL

Signed-off-by: Ulrich Mertin <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…on for Becker BoxCTRL (openhab#10593)

- Corrected typo in German translation and added documentation for Becker BoxCTRL

Signed-off-by: Ulrich Mertin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants