Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Fix the thresholds for the WifiStatus channel #10544

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[netatmo] Fix the thresholds for the WifiStatus channel #10544

merged 1 commit into from
Apr 20, 2021

Conversation

lolodomo
Copy link
Contributor

Fix #10540

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo changed the title [netatmo] Fix the thresholds for the WifiStatus channel [WIP][netatmo] Fix the thresholds for the WifiStatus channel Apr 18, 2021
@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label Apr 18, 2021
@lolodomo
Copy link
Contributor Author

I am going to check how good are the new thresholds by moving the station at different places in my house and compare with what is showing the Netatmo app.

@lolodomo
Copy link
Contributor Author

This is clearly not obvious to experiment !
But I believe that the first value leading to a switch from 4 bars to 3 bars is 55 and the first value leading to a switch from 3 bars to 2 bars is 70.
That would mean we should use 69 and 54 as thresholds.
I will have now difficulty to experiment lower quality Wifi, I should move the station outside the house for that !!

@lolodomo
Copy link
Contributor Author

Small house, small garden. Even in the garden, the wifi connection is between average and good.
So I stop the experimentations. The new values are probably not so bad, certainly better than the previous ones.

@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label Apr 19, 2021
@lolodomo lolodomo changed the title [WIP][netatmo] Fix the thresholds for the WifiStatus channel [netatmo] Fix the thresholds for the WifiStatus channel Apr 19, 2021
cweitkamp
cweitkamp approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added this to the 3.1 milestone Apr 20, 2021
@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Apr 20, 2021
@cweitkamp cweitkamp merged commit 1368b13 into openhab:main Apr 20, 2021
@lolodomo lolodomo deleted the wifistatus branch April 21, 2021 07:15
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@lolodomo @themillhousegroup
[netatmo] Fix the thresholds for the WifiStatus channel (openhab#10544)
7bacb81 
Fix openhab#10540

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: John Marshall <[email protected]>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@lolodomo @computergeek1507
[netatmo] Fix the thresholds for the WifiStatus channel (openhab#10544)
c21a48d 
Fix openhab#10540

Signed-off-by: Laurent Garnier <[email protected]>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@lolodomo @frederictobiasc
[netatmo] Fix the thresholds for the WifiStatus channel (openhab#10544)
d37793f 
Fix openhab#10540

Signed-off-by: Laurent Garnier <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@lolodomo @thinkingstone
[netatmo] Fix the thresholds for the WifiStatus channel (openhab#10544)
59d83fc 
Fix openhab#10540

Signed-off-by: Laurent Garnier <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@lolodomo
[netatmo] Fix the thresholds for the WifiStatus channel (openhab#10544)
299c02e 
Fix openhab#10540

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@clinique clinique clinique approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[netatmo] WifiStatus channel never set to "excellent"
3 participants
@lolodomo @clinique @cweitkamp