Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airthings] Add support for Airthings Wave Mini #10456

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer [email protected]

@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Apr 4, 2021
@kaikreuzer kaikreuzer requested a review from a team April 4, 2021 17:40
@kaikreuzer kaikreuzer requested a review from paulianttila as a code owner April 4, 2021 17:40
@paulianttila
Copy link
Contributor

@kaikreuzer Wave+ doesn't work anymore with bluegiga adapter, but I also tested with main branch without these changes and Wave+ doesn't work there either, so I guess your changes aren't the root cause.

I have been ones again struggled 6 hours with the Eclipse IDE and debugging :( Especially, when change the brach, debugging just don't work. I don't know what kind of black magic it need, but crying seems to help sometimes.

@kaikreuzer
Copy link
Member Author

@paulianttila I own a Wave+ and a Wave mini and both work with this PR - I have it running on my prod system (and yes, I am also using the Bluegiga-adapter).

The only issue I noticed is that the discovery is a bit flaky and often the device appears as a bluetooth beacon instead of an airthings device in the inbox. But this is no problem with the airthings bundle, but with the generic bluetooth discovery service.

@kaikreuzer
Copy link
Member Author

kaikreuzer commented Apr 11, 2021

If you prefer to test on a distro and not in the IDE, you can try out this jar:
org.openhab.binding.bluetooth.airthings-3.1.0-SNAPSHOT.zip (Note: It requires a current snapshot distro, since a bluetooth refactoring was merged a few days ago).

@paulianttila
Copy link
Contributor

paulianttila commented Apr 11, 2021

I own a Wave+ and a Wave mini and both work with this PR - I have it running on my prod system (and yes, I am also using the Bluegiga-adapter).

Thats great.

As I was not able to get it work in IDE, I actually build it my self, but tested with 3.1.0.M3. There was breaking change introduced couple of days ago (#8970), so that's was the reason why it didn't work. I downloaded latest nightly build and it seems to work fine. 👍

Hah...you added note about that as well

Copy link
Contributor

@paulianttila paulianttila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 2e42126 into openhab:main Apr 16, 2021
@fwolter fwolter added this to the 3.1 milestone Apr 16, 2021
@kaikreuzer kaikreuzer deleted the atm branch April 18, 2021 09:39
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants