-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[airthings] Add support for Airthings Wave Mini #10456
Conversation
Signed-off-by: Kai Kreuzer <[email protected]>
@kaikreuzer Wave+ doesn't work anymore with bluegiga adapter, but I also tested with main branch without these changes and Wave+ doesn't work there either, so I guess your changes aren't the root cause. I have been ones again struggled 6 hours with the Eclipse IDE and debugging :( Especially, when change the brach, debugging just don't work. I don't know what kind of black magic it need, but crying seems to help sometimes. |
@paulianttila I own a Wave+ and a Wave mini and both work with this PR - I have it running on my prod system (and yes, I am also using the Bluegiga-adapter). The only issue I noticed is that the discovery is a bit flaky and often the device appears as a bluetooth beacon instead of an airthings device in the inbox. But this is no problem with the airthings bundle, but with the generic bluetooth discovery service. |
If you prefer to test on a distro and not in the IDE, you can try out this jar: |
Thats great. As I was not able to get it work in IDE, I actually build it my self, but tested with 3.1.0.M3. There was breaking change introduced couple of days ago (#8970), so that's was the reason why it didn't work. I downloaded latest nightly build and it seems to work fine. 👍 Hah...you added note about that as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: John Marshall <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer [email protected]