[pulseaudio] Add pulseaudio sink as openhab audio sink #10423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/pulse-audio-binding/74265/25 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
dalgwen
requested review from
bobadair,
caffineehacker,
cweitkamp,
FlorianSW,
fwolter,
gbicskei,
kaikreuzer,
limdul79,
marcelrv,
markus7017,
mherwege,
Skinah and
Stratehm
as code owners
dalgwen
force-pushed
the
1895-pulseaudio_Use_sinks_for_output
branch
from
4f79eb6 to
bd8309d
Compare
This add to the pulseaudio binding the capability to use "pulseaudio sink" as an "openhab sink" to output sound from openhab to a pulse audio server on the network. You need to load module-simple-protocol-tcp sink in addition to the usual module-cli-protocol-tcp, and enable the sink in the thing configuration. Closes openhab#1895 Signed-off-by: Gwendal Roulleau <[email protected]>
dalgwen
force-pushed
the
1895-pulseaudio_Use_sinks_for_output
branch
from
bd8309d to
f7396ac
Compare
fwolter
requested changes
Apr 2, 2021
...ng.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSink.java
Outdated
Show resolved
Hide resolved
...ng.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSink.java
Outdated
Show resolved
Hide resolved
...seaudio/src/main/java/org/openhab/binding/pulseaudio/internal/handler/PulseaudioHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.pulseaudio/src/main/resources/OH-INF/thing/sink.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.pulseaudio/src/main/resources/OH-INF/thing/sink.xml
Outdated
Show resolved
Hide resolved
...ng.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSink.java
Show resolved
Hide resolved
dalgwen
force-pushed
the
1895-pulseaudio_Use_sinks_for_output
branch
2 times, most recently
from
6d35e29 to
d96fd59
Compare
fwolter
requested changes
Apr 2, 2021
...ng.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSink.java
Outdated
Show resolved
Hide resolved
And getting rid of some other compilation warnings Signed-off-by: Gwendal Roulleau <[email protected]>
… module remotely Signed-off-by: Gwendal Roulleau <[email protected]>
dalgwen
force-pushed
the
1895-pulseaudio_Use_sinks_for_output
branch
from
d96fd59 to
9fb5a19
Compare
fwolter
requested changes
Apr 4, 2021
...nding.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseaudioClient.java
Outdated
Show resolved
Hide resolved
...seaudio/src/main/java/org/openhab/binding/pulseaudio/internal/handler/PulseaudioHandler.java
Outdated
Show resolved
Hide resolved
initialize audiosink in a thread with scheduler.submit clear some warning related code. Signed-off-by: Gwendal Roulleau <[email protected]> Better interruptexception handling
dalgwen
force-pushed
the
1895-pulseaudio_Use_sinks_for_output
branch
from
9a79e29 to
80af598
Compare
Signed-off-by: Gwendal Roulleau <[email protected]>
dalgwen
force-pushed
the
1895-pulseaudio_Use_sinks_for_output
branch
from
a46e54c to
9e269b8
Compare
cweitkamp
added
the
enhancement
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…openhab#10423) * [pulseaudio] Add pulseaudio sink as openhab audio sink (openhab#1895) This add to the pulseaudio binding the capability to use "pulseaudio sink" as an "openhab sink" to output sound from openhab to a pulse audio server on the network. You need to load module-simple-protocol-tcp sink in addition to the usual module-cli-protocol-tcp, and enable the sink in the thing configuration. Closes openhab#1895 Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after review And getting rid of some other compilation warnings Signed-off-by: Gwendal Roulleau <[email protected]> * Fix some registration errors and allow the binding to load the simple module remotely Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after reviews initialize audiosink in a thread with scheduler.submit clear some warning related code. Signed-off-by: Gwendal Roulleau <[email protected]> Better interruptexception handling * Fix two small concurrency bugs Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]> Signed-off-by: John Marshall <[email protected]>
wborn
changed the title
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…openhab#10423) * [pulseaudio] Add pulseaudio sink as openhab audio sink (openhab#1895) This add to the pulseaudio binding the capability to use "pulseaudio sink" as an "openhab sink" to output sound from openhab to a pulse audio server on the network. You need to load module-simple-protocol-tcp sink in addition to the usual module-cli-protocol-tcp, and enable the sink in the thing configuration. Closes openhab#1895 Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after review And getting rid of some other compilation warnings Signed-off-by: Gwendal Roulleau <[email protected]> * Fix some registration errors and allow the binding to load the simple module remotely Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after reviews initialize audiosink in a thread with scheduler.submit clear some warning related code. Signed-off-by: Gwendal Roulleau <[email protected]> Better interruptexception handling * Fix two small concurrency bugs Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…openhab#10423) * [pulseaudio] Add pulseaudio sink as openhab audio sink (openhab#1895) This add to the pulseaudio binding the capability to use "pulseaudio sink" as an "openhab sink" to output sound from openhab to a pulse audio server on the network. You need to load module-simple-protocol-tcp sink in addition to the usual module-cli-protocol-tcp, and enable the sink in the thing configuration. Closes openhab#1895 Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after review And getting rid of some other compilation warnings Signed-off-by: Gwendal Roulleau <[email protected]> * Fix some registration errors and allow the binding to load the simple module remotely Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after reviews initialize audiosink in a thread with scheduler.submit clear some warning related code. Signed-off-by: Gwendal Roulleau <[email protected]> Better interruptexception handling * Fix two small concurrency bugs Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…openhab#10423) * [pulseaudio] Add pulseaudio sink as openhab audio sink (openhab#1895) This add to the pulseaudio binding the capability to use "pulseaudio sink" as an "openhab sink" to output sound from openhab to a pulse audio server on the network. You need to load module-simple-protocol-tcp sink in addition to the usual module-cli-protocol-tcp, and enable the sink in the thing configuration. Closes openhab#1895 Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after review And getting rid of some other compilation warnings Signed-off-by: Gwendal Roulleau <[email protected]> * Fix some registration errors and allow the binding to load the simple module remotely Signed-off-by: Gwendal Roulleau <[email protected]> * Small corrections after reviews initialize audiosink in a thread with scheduler.submit clear some warning related code. Signed-off-by: Gwendal Roulleau <[email protected]> Better interruptexception handling * Fix two small concurrency bugs Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the pulseaudio binding the capability to use "pulseaudio sink" as an "openhab sink" to output sound from openhab to a pulse audio server on the network.
You need to load module-simple-protocol-tcp sink in addition to the usual module-cli-protocol-tcp, and enable the sink in the thing configuration
Binding release :
https://github.com/dalgwen/openhab-addons/releases/tag/3.1.0-SNAPSHOT-Audiosink
Closes #1895
Signed-off-by: Gwendal Roulleau [email protected]