[ahawastecollection] Initial Contribution #10387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwolter
changed the title
fwolter
added
the
new binding
fwolter
requested changes
Mar 26, 2021
...src/main/java/org/openhab/binding/ahawastecollection/internal/AhaWasteCollectionHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.ahawastecollection/src/main/resources/OH-INF/binding/binding.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.ahawastecollection/src/main/resources/OH-INF/binding/binding.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.ahawastecollection/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.ahawastecollection/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
|
I installed the binding successfully on my productive OH system. I find the grabbing of the data from the form a bit confusing as the "Abholplatz" didn't show up at the first request and the form variable is called "ladeort". Maybe you could add a screenshot of the developer console showing the values. The "_DE" in the i18n filename needs to be removed to function properly. |
|
@fwolter Thanks for your review and the remarks - most of them are already fixed.
|
|
I opened and issue: openhab/openhab-core#2261 |
soenkekueper
force-pushed
the
ahawastecollection
branch
from
7210ba6 to
2258b68
Compare
|
See the discussion in above issue. The locale identifier should be |
soenkekueper
force-pushed
the
ahawastecollection
branch
from
2258b68 to
ce00716
Compare
soenkekueper
force-pushed
the
ahawastecollection
branch
from
b1a6562 to
eb687f9
Compare
fwolter
requested changes
Apr 27, 2021
| if (command instanceof RefreshType) { | ||
| this.scheduler.execute(this::updateCollectionDates); | ||
| } else { | ||
| this.logger.warn("The AHA Abfuhrkalender is a read-only binding and can not handle commands"); //$NON-NLS-1$ |
bundles/org.openhab.binding.ahawastecollection/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.ahawastecollection/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
soenkekueper
force-pushed
the
ahawastecollection
branch
from
38635ca to
7e903c0
Compare
Signed-off-by: Sönke Küper <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
Signed-off-by: Sönke Küper <[email protected]>
soenkekueper
force-pushed
the
ahawastecollection
branch
from
7e903c0 to
08ad87c
Compare
|
Your code doesn't compile as it has formatting issues. |
Signed-off-by: Sönke Küper <[email protected]>
fwolter
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
LGTM
Now, you could add your binding's logo to the openHAB website. See https://deploy-preview-1540--openhab-docs-preview.netlify.app/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Signed-off-by: Sönke Küper <[email protected]> Signed-off-by: John Marshall <[email protected]>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Sönke Küper <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
Signed-off-by: Sönke Küper <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Sönke Küper <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Sönke Küper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sönke Küper [email protected]
Closes: #10386
This PR implements an binding for the aha waste collection schedule.
It allows users to request the next collection days for several waste types at an specified location.
It therefore basically uses the schedule provided at aha Abfuhrkalender and retrieves the next collection days and supplies them as date channel values.