Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpstracker] Forced channel triggering without previous state #10356

Merged
merged 1 commit into from
Mar 31, 2021
Merged

[gpstracker] Forced channel triggering without previous state #10356

merged 1 commit into from
Mar 31, 2021

Conversation

gbicskei
Copy link
Member

Users were complaining about missing region channel triggering after OH restarts. Region channel triggering doesn't depend on binding's previous state anymore:

  • In case a location message is received it will trigger the channel if based on the the new calculated distance the state differs from the previous state (now this includes the NULL state as well). So after an OH restart the linked switch will be updated even after the first location message

  • In case the message is a transition (e.g. configured in OT application) the trigger event is forced regardless on any previous states

Fixes #6939

@Skinah Skinah added the work in progress A PR that is not yet ready to be merged label Mar 21, 2021
@gbicskei gbicskei changed the title [gpstracker][WIP] Forced channel triggering without previous state [gpstracker] Forced channel triggering without previous state Mar 21, 2021
@gbicskei gbicskei added awaiting feedback Awaiting feedback from the pull request author enhancement An enhancement or new feature for an existing add-on and removed work in progress A PR that is not yet ready to be merged awaiting feedback Awaiting feedback from the pull request author labels Mar 21, 2021
@kaikreuzer kaikreuzer merged commit d64f133 into openhab:main Mar 31, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Mar 31, 2021
Daniel-42 pushed a commit to Daniel-42/openhab-addons that referenced this pull request Apr 6, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gpstracker] Always pass through region enter/leave events from OwnTracks
3 participants