-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[somfytahoma] Setting of channels at init + UoM for channels #10300
Conversation
Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <[email protected]>
70c6904
to
ec40f15
Compare
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found a missing case in a switch, otherwise LGTM
Signed-off-by: Laurent Garnier <[email protected]>
@octa22 : can you please approve now? |
@openhab/add-ons-maintainers : is it possible to have a review & merge of this PR which is now validated by the binding author ? |
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Show resolved
Hide resolved
Signed-off-by: Laurent Ganier <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <[email protected]>
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: John Marshall <[email protected]>
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <[email protected]>
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <[email protected]>
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <[email protected]>
Fix #10291
Fix #10285
Signed-off-by: Laurent Garnier [email protected]