Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[somfytahoma] Setting of channels at init + UoM for channels #10300

Merged
merged 4 commits into from
Mar 14, 2021

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Mar 7, 2021

Fix #10291
Fix #10285

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from octa22 as a code owner March 7, 2021 20:17
@lolodomo lolodomo force-pushed the somfytahoma_initchannels branch from 70c6904 to ec40f15 Compare March 7, 2021 20:34
Copy link
Contributor

@octa22 octa22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found a missing case in a switch, otherwise LGTM

@lolodomo
Copy link
Contributor Author

@octa22 : can you please approve now?

@lolodomo
Copy link
Contributor Author

@openhab/add-ons-maintainers : is it possible to have a review & merge of this PR which is now validated by the binding author ?

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fwolter fwolter merged commit 849442c into openhab:main Mar 14, 2021
@fwolter fwolter added this to the 3.1 milestone Mar 14, 2021
@lolodomo lolodomo deleted the somfytahoma_initchannels branch March 14, 2021 13:25
arjanmels pushed a commit to arjanmels/openhab2-addons that referenced this pull request Mar 14, 2021
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Apr 2, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
4 participants