Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] Make usage of mDNS configurable #10286

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Mar 6, 2021

one of the recent PR has introduced the logic to re-use mDNS service of openHAB instead of creation of a new mDNS instance just for HomeKit. this should reduce the memory footprint.

however, this change led to some connection issues, especially if openHAB runs in a docker container.
https://community.openhab.org/t/homekit-no-response-error-on-all-openhab-items/118200/22

this PR

Signed-off-by: Eugen Freiter [email protected]

Signed-off-by: Eugen Freiter <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/homekit-no-response-error-on-all-openhab-items/118200/23

@yfre yfre added the bug An unexpected problem or unintended behavior of an add-on label Mar 6, 2021
@yfre yfre linked an issue Mar 6, 2021 that may be closed by this pull request
Copy link
Contributor

@Cossey Cossey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openHAB runs under docker in my setup and this has resolved the issue I was facing when I upgraded from 3.1.0.M1 -> 3.1.0.M2 and homekit would sporadically stop working until the bundle was restarted.

Might be worth making a note in the readme regarding the useOHmDNS setting and that it should be Off when being used in docker.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/homekit-no-response-error-on-all-openhab-items/118200/39

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-1-milestone-discussion/116025/50

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit e7950dd into openhab:main Mar 12, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Mar 12, 2021
@kaikreuzer kaikreuzer changed the title [homekit] make usage of mDNS configurable [homekit] Make usage of mDNS configurable Mar 12, 2021
arjanmels pushed a commit to arjanmels/openhab2-addons that referenced this pull request Mar 14, 2021
* make usage of mDNS configurable

Signed-off-by: Eugen Freiter <[email protected]>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* make usage of mDNS configurable

Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: John Marshall <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/homekit-no-longer-functioning/34580/21

computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
* make usage of mDNS configurable

Signed-off-by: Eugen Freiter <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* make usage of mDNS configurable

Signed-off-by: Eugen Freiter <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* make usage of mDNS configurable

Signed-off-by: Eugen Freiter <[email protected]>
@yfre yfre deleted the mnds_switch branch November 15, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[homekit] Description of Outlet accessory type "InUseStatus" misleading
4 participants