-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chromecast] Added play URL actions to chromecast binding #10245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computergeek1507
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Feb 26, 2021
Signed-off-by: Scott Hanson <[email protected]>
computergeek1507
force-pushed
the
chromecast_action
branch
from
February 26, 2021 03:27
90725da
to
a6b04b7
Compare
fwolter
requested changes
Mar 13, 2021
...romecast/src/main/java/org/openhab/binding/chromecast/internal/action/ChromecastActions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Scott Hanson <[email protected]>
fwolter
approved these changes
Mar 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kaikreuzer Do you want to take another look, as the code owner? 135 lines
kaikreuzer
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Mar 14, 2021
kaikreuzer
approved these changes
Mar 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
) * Added play url actions to chromeCast binding Signed-off-by: Scott Hanson <[email protected]> Signed-off-by: John Marshall <[email protected]>
computergeek1507
added a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
) * Added play url actions to chromeCast binding Signed-off-by: Scott Hanson <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
) * Added play url actions to chromeCast binding Signed-off-by: Scott Hanson <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
) * Added play url actions to chromeCast binding Signed-off-by: Scott Hanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added play URL actions to chromecast binding. URL and mimeType can be passed to the chromecast binding.
Signed-off-by: Scott Hanson [email protected] (github: computergeek1507)