Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homematic] Additional check for convert to double #10224

Merged
merged 1 commit into from
Feb 28, 2021

Conversation

Piwoxar
Copy link
Contributor

@Piwoxar Piwoxar commented Feb 24, 2021

In the homematic ccu I can create system variables of type enum.
In method parse() of class CcuVariablesAndScriptsParser the attributes entry.minValue and entry.maxValue contains in this case "" and "" can't be converted to a double. So an exception was raise.

With this additional check the exception doesn't occurs anymore.

Copy link
Contributor Author

@Piwoxar Piwoxar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with signing. At least I hope so.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

Looks like the sign-off is still missing.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Feb 28, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Feb 28, 2021
@kaikreuzer kaikreuzer merged commit 583509e into openhab:main Feb 28, 2021
@Piwoxar Piwoxar deleted the branch_p branch March 1, 2021 16:43
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Hans-Dietert Loew <[email protected]>
Signed-off-by: John Marshall <[email protected]>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants