Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loxone] Support for HTTPS websocket connections. #10185

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

ppieczul
Copy link
Contributor

With generation 2 of Loxone Miniserver, it is possible to use HTTPS websocket connection to the Miniserver. This PR adds support for it. HTTP connections are still used for some of the commands which receive insensitive data during connection process. The possibility to connect to GEN2 Miniservers over HTTP can be removed in the near future.
What is added:

  • new parameter to pass HTTPS port
  • new parameter to force HTTP or HTTPS connection (the method to determine what is supported by Miniserver is adviced by the API document, but it is not confirmed that it works in all cases)
  • reading new remote configuration parameter to determine if HTTPS is supported
  • using HTTPS websocket if possible - all certificates are accepted, it is often the case the Miniservers use locally generated certificates
  • when HTTPS is used, the commands and responses encryption in the binding is disabled

Signed-off-by: Pawel Pieczul [email protected]

@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Feb 17, 2021
@ppieczul ppieczul requested a review from cpmeister February 18, 2021 19:34
@ppieczul
Copy link
Contributor Author

@Hilbrand @cpmeister any chance you could review this PR? Thanks

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 3a19b29 into openhab:main Feb 25, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 25, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants