Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[voicerss] Add support for voices #10184

Merged
merged 2 commits into from
Feb 20, 2021
Merged

[voicerss] Add support for voices #10184

merged 2 commits into from
Feb 20, 2021

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier [email protected]

@lolodomo
[voicerss] Add support for voices
7636c8b 
Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo
Copy link
Contributor Author

This is a working and fully tested alternative to PR #10167

@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Feb 17, 2021
@lolodomo
Consider review comments
604c039 
Signed-off-by: Laurent Garnier <[email protected]>
fwolter
fwolter approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 17f7041 into openhab:main Feb 20, 2021
@fwolter fwolter added this to the 3.1 milestone Feb 20, 2021
@lolodomo lolodomo deleted the voicerss_voices branch February 20, 2021 18:22
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@lolodomo @themillhousegroup
[voicerss] Add support for voices (openhab#10184)
8100ca5 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: John Marshall <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@lolodomo @thinkingstone
[voicerss] Add support for voices (openhab#10184)
f3b71d8 
Signed-off-by: Laurent Garnier <[email protected]>
@EddieParis
Copy link

Hi, can you update the doc as well, because it is really misleading and hiding your great work. By reading doc I understand there is no way to change voice, especially due to this phrase :

"It actually supports only one voice: "voicerss:default", which is configured to use 44kHz, mono, 16 bit sampling quality."

I suggest

use Parameters -> System Services -> Voice to setup the desired language/voice

And again, thanks for all your great work.

@lolodomo
Copy link
Contributor Author

I suggest

use Parameters -> System Services -> Voice to setup the desired language/voice

And again, thanks for all your great work.

You are welcome to submit a PR to update the documentation.
The file is here: https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.voice.voicerss/README.md

@lolodomo
Copy link
Contributor Author

lolodomo commented Jan 22, 2022 •
edited
Loading

I finally updated the documentation myself. PR is submitted.

@EddieParis
Copy link

Great Thanks, I'll have a look !

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@lolodomo
[voicerss] Add support for voices (openhab#10184)
f103e03 
Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lolodomo @EddieParis @fwolter @Hilbrand