[homematic] Remove dependency org.apache.commons.* from AbstractHomematicGateway #10027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mematicGateway Since id is set in the constructor, it is not null and calling StringUtils.upperCase(id) does the same as id.toUpperCase() Signed-off-by: Paul Vogel <[email protected]>
|
@pavog don't know how far along you are with removing org.apache.commons, but I expect to post a PR tonight or tomorrow removing org.apache.commons from all classes. I just want to inform you so that you do not make too much work for yourself, because I have finished the work and the changes will need some tests and review. |
cpmeister
reviewed
Feb 4, 2021
| @@ -800,7 +799,7 @@ public HomematicGatewayAdapter getGatewayAdapter() { | |||
| * Creates a virtual device for handling variables, scripts and other special gateway functions. | |||
| */ | |||
| private HmDevice createGatewayDevice() { | |||
| String type = String.format("%s-%s", HmDevice.TYPE_GATEWAY_EXTRAS, StringUtils.upperCase(id)); | |||
| String type = String.format("%s-%s", HmDevice.TYPE_GATEWAY_EXTRAS, id.toUpperCase()); | |||
There was a problem hiding this comment.
Is there any chance that the id is null? The class doesn't have a @NonNullByDefault so the null checker isn't guaranteeing that it isn't null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency org.apache.commons.lang.StringUtils from AbstractHomematicGateway
Since id is set in the constructor, it is not null and calling StringUtils.upperCase(id) does the same as id.toUpperCase() and is not needed here.
Related to #7722