Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spotify] Duplicated Spotify Connect devices are not removed from the Inbox. #7400

Closed
radokristof opened this issue Apr 17, 2020 · 5 comments · Fixed by #11370
Closed

[spotify] Duplicated Spotify Connect devices are not removed from the Inbox. #7400

radokristof opened this issue Apr 17, 2020 · 5 comments · Fixed by #11370
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@radokristof
Copy link
Contributor

The Inbox is filling up with the same device (which I don't want to include in my system) and old ones are not removed automatically. Would be great if these could be removed.

Expected Behavior

Only one Inbox Item /device in the Inbox.

Current Behavior

The Inbox is filling up with the same device.

Possible Solution

When the device is discovered, check if the device is already in the Inbox or not. If yes, remove the old one first.

Your Environment

  • Version used: openHAB 2.5.3
  • Operating System and version (desktop or mobile, Windows 10, Raspbian Buster, ...): Raspbian Buster
@radokristof radokristof added the bug An unexpected problem or unintended behavior of an add-on label Apr 17, 2020
@radokristof
Copy link
Contributor Author

@Hilbrand This still exists on 2.5.4 as well.

@Hilbrand
Copy link
Member

I tried to reproduce this and looked at the core code, but can't find a reason this happens. By design the discovery framework should always remove old things not found anymore. So there might be some condition why this happens in this specific case, but I don't know what it is. It might be something to do with detecting the same device, but one that get some different data causing to not be seen as the same device. Only a different id should not be a problem as that should be handled.

@radokristof
Copy link
Contributor Author

Which devices did you tried?
I did not see that until now, that it seems that only a few of them are re-appearing... Most of my "real" Spotify Connect devices are added to openHAB, but few of them are not (like Chromecasts), and these are not showing up again, only once. Only phones/Spotify app clients showing up again and again, like phones/tablets/PCs, which are not "real" devices if you know what I mean, you can just control them through any Spotify client...
And I think they are always a "new" device, but I don't know why... Maybe because they are not present in Spotify always, just when you have launched the Spotify app.
What about checking device name? It is too broad and might hide other devices as well?

@AJErazzor
Copy link

I still get this issue with 2.5.5 - duplicate discovered spotify connect devices in the inbox. If I leave them there to build up long enough I end up with OOM errors too.

Hilbrand added a commit to Hilbrand/openhab-addons that referenced this issue Oct 11, 2021
@Hilbrand
[spotify] Various enhancements and fixes
6961b2c 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hilbrand added a commit to Hilbrand/openhab-addons that referenced this issue Oct 11, 2021
@Hilbrand
[spotify] Various enhancements and fixes
c84ddf6 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hilbrand added a commit to Hilbrand/openhab-addons that referenced this issue Oct 11, 2021
@Hilbrand
[spotify] Various enhancements and fixes
b4e4d13 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hilbrand added a commit to Hilbrand/openhab-addons that referenced this issue Oct 11, 2021
@Hilbrand
[spotify] Various enhancements and fixes
61fe39f 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@Hilbrand Hilbrand mentioned this issue Oct 11, 2021
Merged
fwolter pushed a commit that referenced this issue Oct 24, 2021
@Hilbrand
[spotify] Various enhancements and fixes (#11370)
196e4e2 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes #6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes #10490).
- Improved handling Spotify API error messages (Closes #11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes #7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/spotify-connect-binding-available/66809/262

dschoepel pushed a commit to dschoepel/openhab-addons that referenced this issue Nov 9, 2021
@Hilbrand @dschoepel
[spotify] Various enhancements and fixes (openhab#11370)
a5014d9 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Dave J Schoepel <[email protected]>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this issue Dec 30, 2021
@Hilbrand @NickWaterton
[spotify] Various enhancements and fixes (openhab#11370)
7531a06 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this issue Jan 28, 2022
@Hilbrand
[spotify] Various enhancements and fixes (openhab#11370)
4ebee9d 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
@Hilbrand
[spotify] Various enhancements and fixes (openhab#11370)
5caa3f9 
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes openhab#6843).

Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes openhab#10490).
- Improved handling Spotify API error messages (Closes openhab#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes openhab#7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[spotify] Various enhancements and fixes Hilbrand/openhab-addons
4 participants
@Hilbrand @AJErazzor @openhab-bot @radokristof