-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enocean] Incorrectly discovers many devices as "Enocean USB300 Dongle" because 0403:6001 is used by many (FTDI) USB to serial converters #4421
Comments
This indeed seems to be a bit too generic @fruggy83 :-( . The FTDI chip is indeed widespread and its product id should not be used to identify specific dongles like the USB300. |
Hi @kaikreuzer, I will see if I can narrow the discovery a little more. |
@wborn I have created a PR, could you check this with your FTDI devices? Thanks a lot 👍 |
wborn
pushed a commit
that referenced
this issue
Dec 28, 2018
…too (#4431) Fixes #4421 Signed-off-by: Daniel Weber <[email protected]>
chaton78
pushed a commit
to chaton78/openhab-addons
that referenced
this issue
Jan 1, 2019
…too (openhab#4431) Fixes openhab#4421 Signed-off-by: Daniel Weber <[email protected]> Signed-off-by: Pascal Larin <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this issue
Sep 15, 2019
…too (openhab#4431) Fixes openhab#4421 Signed-off-by: Daniel Weber <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Finally I had a look at how the
UsbSerialDiscoveryParticipant
works by inspecting theEnOceanUsbSerialDiscoveryParticipant
.Apparently it uses a very common USB vendor/product ID for matching the Dongle:
https://github.com/openhab/openhab2-addons/blob/af628c6a58bf8f7334dbcb1617147ec62c08fb6d/addons/binding/org.openhab.binding.enocean/src/main/java/org/openhab/binding/enocean/internal/discovery/EnOceanUsbSerialDiscoveryParticipant.java#L40-L41
All the USB to serial devices I use with openHAB have this vendor/product ID:
With
lsusb
it shows up as:So this greatly limits the usefulness of this kind of discovery.
Here's a screenshot of one of my Plugwise Sticks being detected as an EnOcean Dongle in Paper UI 😢 :
The text was updated successfully, but these errors were encountered: