Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdpowerview] Update position Channels immediately when a Scene (Collection) is triggered. #11697

Closed
andrewfg opened this issue Dec 4, 2021 · 2 comments · Fixed by #11768
Closed

[hdpowerview] Update position Channels immediately when a Scene (Collection) is triggered. #11697

andrewfg opened this issue Dec 4, 2021 · 2 comments · Fixed by #11768
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@andrewfg
Copy link
Contributor

andrewfg commented Dec 4, 2021

In Issue #11557 @arroyoj suggested the following:

I would .. suggest doing a soft refresh after any scene is triggered. As far as I can tell from my testing, the hub responds to a GET /shades call with the correct JSON data for all the shade states immediately after a scene is triggered, even while the shades are still moving, so a soft refresh should be sufficient.

In addition logically a soft refresh should probably also be done when a Scene Collection is triggered (see merged PR #11534 from @jlaur).
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Dec 4, 2021
@jlaur
Copy link
Contributor

jlaur commented Dec 4, 2021

@arroyoj, @andrewfg - I can do this, but would prefer to do it after #11637 is merged as there will be a lot of conflicts after changing this part of the code. Would that be okay? Hoping also that @andrewfg would be willing to review the changes made in that PR.

@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 4, 2021

prefer to do it after #11637 is merged.. .. Would that be okay?
Hoping also that @andrewfg would be willing to review

Yes, and yes.

jlaur added a commit to jlaur/openhab-addons that referenced this issue Dec 12, 2021
@jlaur
Update positions after triggering scene/scene group.
f8c009a 
Fixes openhab#11697

Signed-off-by: Jacob Laursen <[email protected]>
@jlaur jlaur mentioned this issue Dec 12, 2021
Merged
lolodomo pushed a commit that referenced this issue Dec 20, 2021
@jlaur
[hdpowerview] Update positions after triggering scene/scene group (#1…
817de38 
…1768)

* Update positions after triggering scene/scene group.
* Compare enum values directly with ==
* Fix re-entrant calls.

Fixes #11697

Signed-off-by: Jacob Laursen <[email protected]>
mherwege pushed a commit to mherwege/openhab-addons that referenced this issue Dec 23, 2021
@jlaur @mherwege
[hdpowerview] Update positions after triggering scene/scene group (op…
fd1383d 
…enhab#11768)

* Update positions after triggering scene/scene group.
* Compare enum values directly with ==
* Fix re-entrant calls.

Fixes openhab#11697

Signed-off-by: Jacob Laursen <[email protected]>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this issue Dec 30, 2021
@jlaur @NickWaterton
[hdpowerview] Update positions after triggering scene/scene group (op…
a35c4bd 
…enhab#11768)

* Update positions after triggering scene/scene group.
* Compare enum values directly with ==
* Fix re-entrant calls.

Fixes openhab#11697

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this issue Jan 9, 2022
@jlaur @mischmidt83
[hdpowerview] Update positions after triggering scene/scene group (op…
86f893e 
…enhab#11768)

* Update positions after triggering scene/scene group.
* Compare enum values directly with ==
* Fix re-entrant calls.

Fixes openhab#11697

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this issue Jan 28, 2022
@jlaur
[hdpowerview] Update positions after triggering scene/scene group (op…
a81ac77 
…enhab#11768)

* Update positions after triggering scene/scene group.
* Compare enum values directly with ==
* Fix re-entrant calls.

Fixes openhab#11697

Signed-off-by: Jacob Laursen <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this issue Nov 6, 2022
@jlaur @andan67
[hdpowerview] Update positions after triggering scene/scene group (op…
d35ef4e 
…enhab#11768)

* Update positions after triggering scene/scene group.
* Compare enum values directly with ==
* Fix re-entrant calls.

Fixes openhab#11697

Signed-off-by: Jacob Laursen <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this issue Nov 12, 2022
@jlaur @andrasU
[hdpowerview] Update positions after triggering scene/scene group (op…
3734e62 
…enhab#11768)

* Update positions after triggering scene/scene group.
* Compare enum values directly with ==
* Fix re-entrant calls.

Fixes openhab#11697

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hdpowerview] Update positions after triggering scene/scene group jlaur/openhab-addons
2 participants
@andrewfg @jlaur