Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Error reading extended device state (water/power consumption) after service #11416

Closed
jlaur opened this issue Oct 19, 2021 · 0 comments · Fixed by #11417
Closed

[miele] Error reading extended device state (water/power consumption) after service #11416

jlaur opened this issue Oct 19, 2021 · 0 comments · Fixed by #11417
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@jlaur
Copy link
Contributor

jlaur commented Oct 19, 2021

After having my washing machine repaired today this started to show up in logs and water/power consumption was no longer updated:

Unexpected size of extended state: [0, 1, 1, 1, 0, 0, 6, 64, 8, 7, 1, 1, 100, 100, 58, -104, 0, 0, 0, 0, 3, -74, 3, -74, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 106, 0, 0, 0, 0, 0, 0, 0, 2, 0, 6, 126, 108, 0, 8, 0, 0, 0, 0, 0, 0, 2]

In total 67 bytes received for ExtendedDeviceState. The two values for water and power consumption were at the same offsets as usual, but 8 more bytes received at the end.

I don't think any software was upgraded, but the machine was factory reset and some configuration changes were made by the Miele technician.

Expected Behavior

Reading of water and power consumption from machines supporting it should work no matter how much extended device state information is available.

Current Behavior

Validation of number of bytes for ExtendedDeviceState is too strict and assumes same length for all firmware versions/configurations.

Possible Solution

Change validation to check only for number of bytes required for reading values from known offsets.

Steps to Reproduce

Create items for either waterConsumption or powerConsumption and run a program on some affected washing machine.

Your Environment

Washing machine: WMV 960 WPS.

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Oct 19, 2021
jlaur added a commit to jlaur/openhab-addons that referenced this issue Oct 19, 2021
kaikreuzer pushed a commit that referenced this issue Oct 21, 2021
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this issue Nov 9, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this issue Dec 30, 2021
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this issue Jan 28, 2022
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
1 participant