[hydrawise] fixes null pointer error for some sprinkler controllers (#…

…13965) Signed-off-by: Dan Cunningham <[email protected]>
openhab · Dec 16, 2022 · ab504bc · ab504bc
1 parent 15ad22b
commit ab504bc
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.../main/java/org/openhab/binding/hydrawise/internal/handler/HydrawiseControllerHandler.java b/.../main/java/org/openhab/binding/hydrawise/internal/handler/HydrawiseControllerHandler.java
@@ -258,8 +258,7 @@ public void onData(List<Controller> controllers) {
             // update values with what the cloud tells us even though the controller may be offline
             if (!controller.status.online) {
                 updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR,
-                        String.format("Controller Offline: %s last seen %s", controller.status.summary,
-                                secondsToDateTime(controller.status.lastContact.timestamp)));
+                        "Service reports controller as offline");
             } else if (getThing().getStatus() != ThingStatus.ONLINE) {
                 updateStatus(ThingStatus.ONLINE);
             }
@@ -277,7 +276,8 @@ private void updateController(Controller controller) {
         updateGroupState(CHANNEL_GROUP_CONTROLLER_SYSTEM, CHANNEL_CONTROLLER_SUMMARY,
                 new StringType(controller.status.summary));
         updateGroupState(CHANNEL_GROUP_CONTROLLER_SYSTEM, CHANNEL_CONTROLLER_LAST_CONTACT,
-                secondsToDateTime(controller.status.lastContact.timestamp));
+                controller.status.lastContact != null ? secondsToDateTime(controller.status.lastContact.timestamp)
+                        : UnDefType.NULL);
     }
 
     private void updateZones(List<Zone> zones) {