Remove duplicated code. (#16393)

Signed-off-by: Alexander Falkenstern <[email protected]>
openhab · Feb 11, 2024 · 473b0ac · 473b0ac
1 parent 4c4f292
commit 473b0ac
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 20 deletions.
diff --git a/...g.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java b/...g.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
@@ -415,7 +415,7 @@ public void handleCommand(ChannelUID channelUID, Command command) {
 
                 case CHANNEL_SENSOR_SLEEPTIME:
                     logger.debug("{}: Set sensor sleep time to {}", thingName, command);
-                    int value = (int) getNumber(command);
+                    int value = getNumber(command).intValue();
                     value = value > 0 ? Math.max(SHELLY_MOTION_SLEEPTIME_OFFSET, value - SHELLY_MOTION_SLEEPTIME_OFFSET)
                             : 0;
                     api.setSleepTime(value);
@@ -432,7 +432,7 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                     logger.debug("{}: Select profile {}", thingName, command);
                     int id = -1;
                     if (command instanceof Number) {
-                        id = (int) getNumber(command);
+                        id = getNumber(command).intValue();
                     } else {
                         String cmd = command.toString();
                         if (isDigit(cmd.charAt(0))) {
@@ -458,7 +458,7 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                     break;
                 case CHANNEL_CONTROL_SETTEMP:
                     logger.debug("{}: Set temperature to {}", thingName, command);
-                    api.setValveTemperature(0, (int) getNumber(command));
+                    api.setValveTemperature(0, getNumber(command).intValue());
                     break;
                 case CHANNEL_CONTROL_POSITION:
                     logger.debug("{}: Set position to {}", thingName, command);
@@ -470,7 +470,7 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                     break;
                 case CHANNEL_CONTROL_BTIMER:
                     logger.debug("{}: Set boost timer to {}", thingName, command);
-                    api.setValveBoostTime(0, (int) getNumber(command));
+                    api.setValveBoostTime(0, getNumber(command).intValue());
                     break;
                 case CHANNEL_SENSOR_MUTE:
                     if (profile.isSmoke && ((OnOffType) command) == OnOffType.ON) {
@@ -514,19 +514,6 @@ public void handleCommand(ChannelUID channelUID, Command command) {
         }
     }
 
-    private double getNumber(Command command) {
-        if (command instanceof QuantityType<?> quantityCommand) {
-            return quantityCommand.doubleValue();
-        }
-        if (command instanceof DecimalType decimalCommand) {
-            return decimalCommand.doubleValue();
-        }
-        if (command instanceof Number numberCommand) {
-            return numberCommand.doubleValue();
-        }
-        throw new IllegalArgumentException("Invalid Number type for conversion: " + command);
-    }
-
     /**
      * Update device status and channels
      */

diff --git a/...ab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/util/ShellyUtils.java b/...ab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/util/ShellyUtils.java
@@ -236,13 +236,16 @@ public static DecimalType getDecimal(@Nullable Long value) {
     }
 
     public static Double getNumber(Command command) throws IllegalArgumentException {
+        if (command instanceof QuantityType<?> quantityCommand) {
+            return quantityCommand.doubleValue();
+        }
         if (command instanceof DecimalType decimalCommand) {
             return decimalCommand.doubleValue();
         }
-        if (command instanceof QuantityType<?> quantityCommand) {
-            return quantityCommand.doubleValue();
+        if (command instanceof Number numberCommand) {
+            return numberCommand.doubleValue();
         }
-        throw new IllegalArgumentException("Unable to convert number");
+        throw new IllegalArgumentException("Invalid Number type for conversion: " + command);
     }
 
     public static OnOffType getOnOff(@Nullable Boolean value) {