This repository has been archived by the owner on Dec 2, 2022. It is now read-only.
Upgrade xml-crypto to 1.0.1, add tests for 100% coverage #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
force-pushed
the
real-sign-tests
branch
from
d14b53d to
e09a99b
Compare
* Pick up [email protected], which contains a fix for node 4.x users * Change the sig tests so that we avoid the use of mocks
* Take the assertion and response xml from MockPass for tests * Bring in mustache as a dependency * Re-jig the tests to use those as inputs so that we can guarantee some consistency
LoneRifle
force-pushed
the
real-sign-tests
branch
from
29ff977 to
183c2d1
Compare
LoneRifle
changed the title
|
lgtm :) |
arshadali172
approved these changes
Sep 13, 2018
LoneRifle
force-pushed
the
real-sign-tests
branch
from
633fd90 to
452ba17
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2