-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Next.js CSR example #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwajiehao
reviewed
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments! happy to discuss them over a call as well
@kwajiehao also made the following changes based on comments from the Next.js SSR PR.
|
raynerljm
force-pushed
the
feat/example-next-csr
branch
2 times, most recently
from
May 16, 2023 10:26
f8d2b62
to
29cf9de
Compare
raynerljm
force-pushed
the
feat/example-next-csr
branch
from
May 17, 2023 10:57
cfa35ee
to
aefc0db
Compare
raynerljm
force-pushed
the
feat/example-next-csr
branch
from
May 22, 2023 02:38
7686d70
to
a1d2f3f
Compare
kwajiehao
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our SDK currently lacks example apps demonstrating how to use our SDK. This introduces two problems
npm link
)Closes #384
Solution
Added an example Next.js app using CSR and API routes. It is hosted here.
Features:
sgid-server
via thesrc/pages/api
routessrc/lib/store.js
to store Session data (e.g. state, nonce, codeVerifier, etc.)Tests
// TODO: ADD recording