Allow multiple possible logins #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create identities object, holding identities for SingPass/CorpPass * Allow assertions to be rendered using either default or specified identities
* Inject the index of the mockpass identities into the saml artifact, appending it as a single byte at the end * Read this byte when receiving the artifact from the service provider; if this index corresponds to a mockpass identity, return that, else return the default one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lay groundwork for identity selection
identities
Implement multiple logins
appending it as a single byte at the end
if this index corresponds to a mockpass identity, return that, else
return the default one
Fixes #1