Mockpass no longer defaults to first NRIC if login page disabled #120
Comments
|
Hey @chadlwilson - thanks for the catch! The change was unintentional, so I'll try to put in a fix for this later today. |
|
Thanks! 🙏 |
justin-tay
pushed a commit
to justin-tay/mockpass
that referenced
this issue
Nov 18, 2020
If `SHOW_LOGIN_PAGE` is not true, the artifact sent to the
`/soap` and `/token` endpoints will translate to an index of -1.
If so, ensure that we default to what was specified in
`assertions.{singPassNric, corpPassNric}`
Fixes opengovsg#120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In earlier versions before
2.5.0, mockpass used to default to the first NRIC in theassertions.saml.singPasslist (or theMOCKPASS_NRICenv var) in the returned SAML artifact, if the login page was disabled.In the current implementation when the login page is disabled, the index in the SAML artifact ID is
-1which then cannot be looked up, and mockpass returns no NRIC in theUserNameinside the SAML Artifact; which is a breaking change for most users I imagine.This seemed to happen in 7f29add - previous code had a default here which no longer exists in the new implementation here
Was this change intentional?
The text was updated successfully, but these errors were encountered: