Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-publish transpile pipeline with Babel #9

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Conversation

liangyuanruo
Copy link
Contributor

Problem

FormSG deployment is facing issues because IE11 does not support ES6 language features.

Solution

Add a pre-publish Babel hook which will ensure that we only distribute transpiled code. The source is transpiled down to IE11-friendly syntax.

@liangyuanruo liangyuanruo requested a review from LoneRifle March 30, 2020 15:13
LoneRifle
LoneRifle previously approved these changes Mar 30, 2020
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liangyuanruo liangyuanruo merged commit e1555ba into master Mar 30, 2020
@liangyuanruo liangyuanruo deleted the transpile branch March 30, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants