Add cryptographic functions to SDK #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FormSG today, with minor changes - Renamed functions to expose a decrypt/encrypt method - To be consistent with decrypt(), encrypt() now accepts an array of Response objects instead of a JSON string - Renamed privateKey to secretKey for consistency with nacl library
lshaowei18
reviewed
Mar 24, 2020
- Import crypto modules statically rather than by calling crypto() - Variable renaming - JSDoc improvements
lshaowei18
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SDK currently contains utilities for web hook signature verification, but is incomplete without the functionality necessary to decrypt form responses.
Solution
This PR adds the following functionality under the
cryptomodule:as well as corresponding tests for the above.
Post-merge
Bump minor version number and publish to NPM.
Reviewers, please take note that this is a public repository.