Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.2.0 - Add signing functions, end-to-end testing #2

Merged
merged 10 commits into from
Mar 2, 2020
Merged

Version 0.2.0 - Add signing functions, end-to-end testing #2

merged 10 commits into from
Mar 2, 2020

Conversation

liangyuanruo
Copy link
Contributor

New

  • Added sign-side functions with generateSignature and constructHeader functions

Improvements

  • End-to-end signing and verification tests

@liangyuanruo liangyuanruo requested a review from yong-jie March 2, 2020 08:48
@liangyuanruo liangyuanruo changed the title Version 0.2.0 - Add signing functions, tests Version 0.2.0 - Add signing functions, end-to-end testing Mar 2, 2020
yong-jie
yong-jie previously approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a little bit magical/scary that this is enough for travis to do its thing

lgtm!

@liangyuanruo liangyuanruo requested a review from yong-jie March 2, 2020 10:12
@liangyuanruo liangyuanruo merged commit 274b783 into master Mar 2, 2020
@liangyuanruo liangyuanruo deleted the test branch March 2, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangyuanruo @yong-jie