Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mrf crypto #101

Merged
merged 18 commits into from
Dec 14, 2023
Merged

feat: mrf crypto #101

merged 18 commits into from
Dec 14, 2023

Conversation

justynoh
Copy link
Contributor

@justynoh justynoh commented Dec 7, 2023

Problem

We want to implement multi-respondent forms. This PR implements the crypto primitives required to encrypt and decrypt multi-respondent form responses.

Solution

A new Crypto class, CryptoV3 is written to support the new encryption scheme. Common functions between Crypto and CryptoV3 are split into a CryptoBase parent class, which Crypto and CryptoV3 now inherit.

Breaking Changes

  • No - this PR is backwards compatible

Copy link

gitguardian bot commented Dec 9, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
9014825 Generic High Entropy Secret ecd7b58 spec/resources/crypto-v3-data-20231207.ts View secret
9014826 Generic High Entropy Secret ecd7b58 spec/resources/crypto-v3-data-20231207.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@justynoh justynoh merged commit cfe99cb into develop Dec 14, 2023
@justynoh justynoh deleted the feat/mrf-crypto branch December 14, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants