Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(if): support Unit types #1340

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix(if): support Unit types #1340

merged 1 commit into from
Nov 10, 2022

Conversation

LoneRifle
Copy link
Contributor

Problem

Dates cannot be used as arguments for ifelse and countif functions

Solution

Allow for Unit data types in evaluator expressions for those functions

@LoneRifle LoneRifle requested a review from lamkeewei November 10, 2022 07:05
lamkeewei
lamkeewei approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@lamkeewei lamkeewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit d6bcd48 into develop Nov 10, 2022
@LoneRifle LoneRifle deleted the fix/if/unit branch November 10, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamkeewei lamkeewei lamkeewei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoneRifle @lamkeewei