feat: Added property to choose default render month/year #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for objective-bell-0ffbfb canceled.
|
cyiafn
force-pushed
the
feat/default-cal-render-my
branch
from
9aa2c17 to
b9e4c02
Compare
karrui
requested changes
Jun 6, 2023
|
Also please do add stories for regression snapshot testing~ |
karrui
requested changes
Jun 6, 2023
cyiafn
force-pushed
the
feat/default-cal-render-my
branch
from
4e8dc49 to
91f0968
Compare
karrui
reviewed
Jun 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The RangeCalendar and Calendar does not allow users to select which month/year to render by default and defaults to Today.
Use case is for querying past data, in which the user might save a click for this kind of scenarios.
This is backwards compatible.
Closes #375
Solution
Allow users to pass in an optional prop to set the default render date.
Before & After Screenshots
BEFORE:
AFTER:
Set to 2005-05-01
Tests