chore: wrap update link stats in a try catch to prevent errors bubbling

opengovsg · Mar 21, 2024 · 842cdc1 · 842cdc1
1 parent 264fa6f
commit 842cdc1
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/server/modules/redirect/services/RedirectService.ts b/src/server/modules/redirect/services/RedirectService.ts
@@ -4,7 +4,7 @@ import { DependencyIds } from '../../../constants'
 import { NotFoundError } from '../../../util/error'
 import { RedirectResult, RedirectType } from '..'
 import { LinkStatisticsService } from '../../analytics/interfaces'
-import { ogUrl } from '../../../config'
+import { logger, ogUrl } from '../../../config'
 import { CookieArrayReducerService, CrawlerCheckService } from '.'
 
 @injectable()
@@ -54,8 +54,12 @@ export class RedirectService {
     const longUrl = await this.urlRepository.getLongUrl(shortUrl)
 
     // Update clicks and click statistics in database.
-    this.linkStatisticsService.updateLinkStatistics(shortUrl, userAgent)
-
+    try {
+      this.linkStatisticsService.updateLinkStatistics(shortUrl, userAgent)
+    } catch (e) {
+      // updates wrapped in a try-catch block to prevent errors from bubbling up
+      logger.warn('error updating link statistics')
+    }
     if (this.crawlerCheckService.isCrawler(userAgent)) {
       return {
         longUrl,