chore: disable link stats temporarily

opengovsg · Mar 21, 2024 · 7cf0e5d · 7cf0e5d
1 parent 822d2db
commit 7cf0e5d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/src/server/modules/redirect/__tests__/RedirectController.test.ts b/src/server/modules/redirect/__tests__/RedirectController.test.ts
@@ -286,8 +286,8 @@ describe('redirect API tests', () => {
       .get<RedirectController>(DependencyIds.redirectController)
       .redirect(req, res)
 
-    expect(updateStatisticsSpy).toBeCalledWith('aaa', userAgent)
-    expect(updateStatisticsSpy).toBeCalledTimes(1)
+    // expect(updateStatisticsSpy).toBeCalledWith('aaa', userAgent)
+    // expect(updateStatisticsSpy).toBeCalledTimes(1)
     expect(res.statusCode).toBe(200)
     expect(res._getRedirectUrl()).toBe('')
     expect(
@@ -315,8 +315,8 @@ describe('redirect API tests', () => {
       .get<RedirectController>(DependencyIds.redirectController)
       .redirect(req, res)
 
-    expect(updateStatisticsSpy).toBeCalledWith('aaa', userAgent)
-    expect(updateStatisticsSpy).toBeCalledTimes(1)
+    // expect(updateStatisticsSpy).toBeCalledWith('aaa', userAgent)
+    // expect(updateStatisticsSpy).toBeCalledTimes(1)
     expect(res.statusCode).toBe(302)
     expect(res._getRedirectUrl()).toBe('aa')
     expect(
@@ -341,8 +341,8 @@ describe('redirect API tests', () => {
       .get<RedirectController>(DependencyIds.redirectController)
       .redirect(req, res)
 
-    expect(updateStatisticsSpy).toBeCalledWith('aaa', userAgent)
-    expect(updateStatisticsSpy).toBeCalledTimes(1)
+    // expect(updateStatisticsSpy).toBeCalledWith('aaa', userAgent)
+    // expect(updateStatisticsSpy).toBeCalledTimes(1)
     expect(res.statusCode).toBe(302)
     expect(res.cookies.gaClientId).toBeTruthy()
     expect(res._getRedirectUrl()).toBe('aa')
@@ -364,8 +364,8 @@ describe('redirect API tests', () => {
       .get<RedirectController>(DependencyIds.redirectController)
       .redirect(req, res)
 
-    expect(updateStatisticsSpy).toBeCalledWith('aaa', '')
-    expect(updateStatisticsSpy).toBeCalledTimes(1)
+    // expect(updateStatisticsSpy).toBeCalledWith('aaa', '')
+    // expect(updateStatisticsSpy).toBeCalledTimes(1)
     expect(res.statusCode).toBe(302)
     expect(res._getRedirectUrl()).toBe('aa')
   })
@@ -380,8 +380,8 @@ describe('redirect API tests', () => {
 
     expect(res.statusCode).toBe(302)
     expect(res._getRedirectUrl()).toBe('aa')
-    expect(updateStatisticsSpy).toBeCalledTimes(1)
-    expect(updateStatisticsSpy).toBeCalledWith('aaa', '')
+    // expect(updateStatisticsSpy).toBeCalledTimes(1)
+    // expect(updateStatisticsSpy).toBeCalledWith('aaa', '')
   })
 
   test('url does not exist in neither cache nor db', async () => {
@@ -411,8 +411,8 @@ describe('redirect API tests', () => {
 
     expect(res.statusCode).toBe(302)
     expect(res._getRedirectUrl()).toBe('aa')
-    expect(updateStatisticsSpy).toBeCalledTimes(1)
-    expect(updateStatisticsSpy).toBeCalledWith('aaa', '')
+    // expect(updateStatisticsSpy).toBeCalledTimes(1)
+    // expect(updateStatisticsSpy).toBeCalledWith('aaa', '')
   })
 
   test('both db and cache down', async () => {

diff --git a/src/server/modules/redirect/services/RedirectService.ts b/src/server/modules/redirect/services/RedirectService.ts
@@ -54,8 +54,9 @@ export class RedirectService {
     const longUrl = await this.urlRepository.getLongUrl(shortUrl)
 
     // Update clicks and click statistics in database.
-    this.linkStatisticsService.updateLinkStatistics(shortUrl, userAgent)
-
+    if (false) {
+      this.linkStatisticsService.updateLinkStatistics(shortUrl, userAgent)
+    }
     if (this.crawlerCheckService.isCrawler(userAgent)) {
       return {
         longUrl,