Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Release 4.52.0 #975

Merged
merged 36 commits into from
Jan 6, 2021
Merged

build: Release 4.52.0 #975

merged 36 commits into from
Jan 6, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Jan 6, 2021 •
edited
Loading

New

  • Bulk Attachment Download Frontend #640
  • feat: send SMS notification when submissions bounce #961
  • feat/type-safe: Encourage type-safe coding practices with eslint-plugin-typesafe #943
  • Show OTP delay notification #748

Improvements

  • refactor: migrate submissions controller to TypeScript #881
  • test: add Joi validation integration tests #933
  • test: add SPCP authentication integration tests #921

Fixes

  • fix(AuthClientCtl): cancel timeout promise on page change #971

Dependency Updates

  • fix: upgrade neverthrow from 3.0.0 to 3.1.2 #968
  • fix(deps): bump @opengovsg/myinfo-gov-client from 2.1.2 to 2.1.3 #924
  • fix(deps): bump @opengovsg/ng-file-upload from 12.2.14 to 12.2.15 #965
  • fix(deps): bump @sentry/browser from 5.29.1 to 5.29.2 #951
  • fix(deps): bump @sentry/integrations from 5.29.0 to 5.29.2 #946
  • fix(deps): bump angular-ui-router from 1.0.28 to 1.0.29 #936
  • fix(deps): bump aws-sdk from 2.805.0 to 2.817.0 #953
  • fix(deps): bump aws-sdk from 2.817.0 to 2.818.0 #956
  • fix(deps): bump axios from 0.21.0 to 0.21.1 #947
  • fix(deps): bump boxicons from 1.8.0 to 1.8.1 #926
  • fix(deps): bump mongoose from 5.11.8 to 5.11.9 #958
  • fix(deps): bump nodemailer from 6.4.16 to 6.4.17 #954
  • fix(deps): bump winston-cloudwatch from 2.4.0 to 2.5.0 #945
  • chore(deps-dev): bump @babel/plugin-transform-runtime #952
  • chore(deps-dev): bump @babel/preset-env from 7.12.7 to 7.12.11 #925
  • chore(deps-dev): bump @opengovsg/mockpass from 2.6.0 to 2.6.1 #960
  • chore(deps-dev): bump @typescript-eslint/eslint-plugin from 4.0.1 to 4.11.0 #927
  • chore(deps-dev): bump @typescript-eslint/parser from 4.10.0 to 4.11.0 #944
  • chore(deps-dev): bump eslint from 7.14.0 to 7.16.0 #955
  • chore(deps-dev): bump eslint-plugin-prettier from 3.1.4 to 3.3.0 #923
  • chore(deps-dev): bump eslint-plugin-simple-import-sort #966
  • chore(deps-dev): bump ngrok from 3.3.0 to 3.4.0 #939
  • chore(deps-dev): bump sinon from 9.2.1 to 9.2.2 #959
  • chore(deps-dev): bump testcafe from 1.9.4 to 1.10.1 #942
  • chore(deps-dev): bump ts-node from 9.0.0 to 9.1.1 #937
  • chore(deps-dev): bump ts-node-dev from 1.0.0 to 1.1.1 #957

dependabot bot and others added 30 commits December 22, 2020 15:04
@dependabot
chore(deps-dev): bump @babel/preset-env from 7.12.7 to 7.12.11 (#925)
31b39aa 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.7 to 7.12.11.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.11/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump eslint-plugin-prettier from 3.1.4 to 3.3.0 (#923)
b0a9fb6 
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 3.1.4 to 3.3.0.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v3.1.4...v3.3.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @opengovsg/myinfo-gov-client from 2.1.2 to 2.1.3 (#924)
4ae6480 
Bumps [@opengovsg/myinfo-gov-client](https://github.com/datagovsg/myinfo-gov-client) from 2.1.2 to 2.1.3.
- [Release notes](https://github.com/datagovsg/myinfo-gov-client/releases)
- [Commits](https://github.com/datagovsg/myinfo-gov-client/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump boxicons from 1.8.0 to 1.8.1 (#926)
367577e 
Bumps [boxicons](https://github.com/atisawd/boxicons) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/atisawd/boxicons/releases)
- [Commits](https://github.com/atisawd/boxicons/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
Merge pull request #932 from opengovsg/release-4.51.0
e282658 
build: merge Release 4.51.0 into develop
@dependabot
fix(deps): bump angular-ui-router from 1.0.28 to 1.0.29 (#936)
6507d4f 
Bumps [angular-ui-router](https://github.com/angular-ui/ui-router) from 1.0.28 to 1.0.29.
- [Release notes](https://github.com/angular-ui/ui-router/releases)
- [Changelog](https://github.com/angular-ui/ui-router/blob/master/CHANGELOG.md)
- [Commits](angular-ui/ui-router@1.0.28...1.0.29)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump ts-node from 9.0.0 to 9.1.1 (#937)
3defbc6 
Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 9.0.0 to 9.1.1.
- [Release notes](https://github.com/TypeStrong/ts-node/releases)
- [Commits](TypeStrong/ts-node@v9.0.0...v9.1.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump ngrok from 3.3.0 to 3.4.0 (#939)
bd3b309 
Bumps [ngrok](https://github.com/bubenshchykov/ngrok) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/bubenshchykov/ngrok/releases)
- [Commits](bubenshchykov/ngrok@v3.3.0...v3.4.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump testcafe from 1.9.4 to 1.10.1 (#942)
892b43d 
Bumps [testcafe](https://github.com/DevExpress/testcafe) from 1.9.4 to 1.10.1.
- [Release notes](https://github.com/DevExpress/testcafe/releases)
- [Changelog](https://github.com/DevExpress/testcafe/blob/master/CHANGELOG.md)
- [Commits](DevExpress/testcafe@v1.9.4...v1.10.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump axios from 0.21.0 to 0.21.1 (#947)
8ff8086 
Bumps [axios](https://github.com/axios/axios) from 0.21.0 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md)
- [Commits](axios/axios@v0.21.0...v0.21.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @typescript-eslint/parser from 4.10.0 to 4.11.0 (…
5a9b3f0 
…#944)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.10.0 to 4.11.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.11.0/packages/parser)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
refactor: migrate submissions controller to TypeScript (#881)
7da2934
@dependabot
fix(deps): bump winston-cloudwatch from 2.4.0 to 2.5.0 (#945)
27283da 
Bumps [winston-cloudwatch](https://github.com/lazywithclass/winston-cloudwatch) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/lazywithclass/winston-cloudwatch/releases)
- [Changelog](https://github.com/lazywithclass/winston-cloudwatch/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lazywithclass/winston-cloudwatch/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/integrations from 5.29.0 to 5.29.2 (#946)
f2d6ed9 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 5.29.0 to 5.29.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@5.29.0...5.29.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
test: add Joi validation integration tests (#933)
ab0fff9
@dependabot
fix(deps): bump nodemailer from 6.4.16 to 6.4.17 (#954)
5139e90 
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.4.16 to 6.4.17.
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.4.16...v6.4.17)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.805.0 to 2.817.0 (#953)
1195047 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.805.0 to 2.817.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.805.0...v2.817.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/plugin-transform-runtime (#952)
23e6dda 
Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.12.1 to 7.12.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.10/packages/babel-plugin-transform-runtime)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @karrui
chore(deps-dev): bump @typescript-eslint/eslint-plugin from 4.0.1 to …
9bc6232 
…4.11.0 (#927)

* chore(deps-dev): bump @typescript-eslint/eslint-plugin

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.0.1 to 4.11.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.11.0/packages/eslint-plugin)

Signed-off-by: dependabot[bot] <[email protected]>

* fix: disable eslint false positive in bson-ext.d.ts

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kar Rui Lau <[email protected]>
@dependabot
fix(deps): bump @sentry/browser from 5.29.1 to 5.29.2 (#951)
b2a3268 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.29.1 to 5.29.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@5.29.1...5.29.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump eslint from 7.14.0 to 7.16.0 (#955)
8c3e7a0 
Bumps [eslint](https://github.com/eslint/eslint) from 7.14.0 to 7.16.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.14.0...v7.16.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.817.0 to 2.818.0 (#956)
e1788ae 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.817.0 to 2.818.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.817.0...v2.818.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump ts-node-dev from 1.0.0 to 1.1.1 (#957)
fe521d6 
Bumps [ts-node-dev](https://github.com/whitecolor/ts-node-dev) from 1.0.0 to 1.1.1.
- [Release notes](https://github.com/whitecolor/ts-node-dev/releases)
- [Changelog](https://github.com/wclr/ts-node-dev/blob/master/CHANGELOG.md)
- [Commits](wclr/ts-node-dev@v1.0.0...v1.1.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump mongoose from 5.11.8 to 5.11.9 (#958)
fecf927 
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.11.8 to 5.11.9.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md)
- [Commits](Automattic/mongoose@5.11.8...5.11.9)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump sinon from 9.2.1 to 9.2.2 (#959)
12e9601 
Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.1 to 9.2.2.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/commits/v9.2.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @opengovsg/mockpass from 2.6.0 to 2.6.1 (#960)
8b5d569 
Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/opengovsg/mockpass/releases)
- [Commits](opengovsg/mockpass@v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
feat: send SMS notification when submissions bounce (#961)
31f6616
@liangyuanruo
feat/type-safe: Encourage type-safe coding practices with eslint-plug…
e6b85a4 
…in-typesafe (#943)

* test: incorporate typesafe/no-throw-sync-func rule.

* refactor: remove need for assertUnreachable in switch statements as can simply rely on type checking against the function return signature. For instance, type checks will fail with  "Not all code paths return a value" in the case below:

```typescript
type MyNumber = 1 | 2

function test(x: MyNumber) {
    switch(x) {
        case 1:
            return 1
    }
}
```

* allow throws from createCustomLogger due to logger imports from JS files
* allows validateS3BucketUrl to throw exceptions because of convict integration
* excludes FeatureManager from no-throw-sync-func

Co-authored-by: Yuanruo Liang <[email protected]>
@snyk-bot
fix: upgrade neverthrow from 3.0.0 to 3.1.2 (#968)
4e378e0 
Snyk has created this PR to upgrade neverthrow from 3.0.0 to 3.1.2.

See this package in npm:
https://www.npmjs.com/package/neverthrow

See this project in Snyk:
https://app.snyk.io/org/open-government-products/project/4c4f5244-5ce5-491a-a42d-c295bc7f51fd?utm_source=github&utm_medium=upgrade-pr
@frankchn @r00dgirl
Bulk Attachment Download Frontend (#640)
9879fdd 
* feat: Bulk Download Frontend Changes (before 2020-12-13)

* Minor styling changes, and add download status for attachment downloads

* Add download status column to the start of the CSV

* Change decryption status to general row status

* always add csv record array

* Remove duplicate CSV processing

* Update test columns and rows to reflect new CSV format

* Change header to 'Download Status' instead of 'Attachment Download Status'

* Update frontend UI design to conform with latest mockups

* Changed 'User Guide' to say 'Help' more succinctly

* Wording changes from @syan-syan

Co-authored-by: syan-syan <[email protected]>
jia1 and others added 5 commits January 5, 2021 17:36
@jia1 @karrui
Show OTP delay notification (#748)
8e6adc0 
* feat: Show OTP delay notification 45 seconds after sending OTP

* fix: run linter

* fix: Fix conditional rendering for sign-in messages and OTP delay notification and update OTP delay notification text

* fix: Fix conditional rendering logic for "Sending OTP..." and OTP delay notification so that the latter takes precedence

* fix: lint

* fix: Change OTP delay from 45s to 20s and set isMsg and showOtpDelayNotification to false whenever sendOtp is called

* fix: Amend sign-in messages

* fix: Fix broken test due to change in sign-in message

Co-authored-by: Kar Rui Lau <[email protected]>
@karrui
fix(AuthClientCtl): cancel timeout promise on page change (#971)
86ea985 
* fix(AuthClientCtl): cancel timeout promise on page change

* feat: move delayed notification timeout to then block instead of catch
@dependabot
chore(deps-dev): bump eslint-plugin-simple-import-sort (#966)
9b64dac 
Bumps [eslint-plugin-simple-import-sort](https://github.com/lydell/eslint-plugin-simple-import-sort) from 6.0.1 to 7.0.0.
- [Release notes](https://github.com/lydell/eslint-plugin-simple-import-sort/releases)
- [Changelog](https://github.com/lydell/eslint-plugin-simple-import-sort/blob/main/CHANGELOG.md)
- [Commits](lydell/eslint-plugin-simple-import-sort@v6.0.1...v7.0.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @opengovsg/ng-file-upload from 12.2.14 to 12.2.15 (#965)
582d706 
Bumps [@opengovsg/ng-file-upload](https://github.com/danialfarid/ng-file-upload) from 12.2.14 to 12.2.15.
- [Release notes](https://github.com/danialfarid/ng-file-upload/releases)
- [Commits](https://github.com/danialfarid/ng-file-upload/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
chore: bump version to 4.52.0
fc575f5
@tshuli
Copy link
Contributor Author

tshuli commented Jan 6, 2021 •
edited
Loading

Bulk attachment download
@tshuli

  • Create storage mode form with attachment field. Submit multiple responses. Test that bulk attachment download works.

@tshuli
Copy link
Contributor Author

tshuli commented Jan 6, 2021 •
edited
Loading

send SMS notification when submissions bounce
@tshuli

  • Create an email mode form and add one valid and one invalid (e.g. non-existent email address) email recipient. Add an editor as well as a read-only collaborator.
  • Submit the form and ensure that you do NOT receive any texts.
  • Replace the valid recipient with another invalid one. Submit the form and check that you AND the collaborator with write permissions receive two texts: one saying that a response has bounced, and another saying that your form was deactivated. ALL collaborators (including the read-only collaborator) should also receive an automated email. Check that each text has a corresponding document in the smscounts collection, with smsType as either BOUNCED_SUBMISSION or FORM_DEACTIVATED.
  • Reactivate the form and submit again. You and the collaborator with write permissions should receive only one text saying that the form was deactivated, and no emails.

@tshuli
Copy link
Contributor Author

tshuli commented Jan 6, 2021 •
edited
Loading

Show OTP delay notification
@tshuli

  • Send login OTP multiple times. After 45 seconds you should see "OTP might be delayed due to government email traffic. If you are unable to sign in, please try again later, or contact us"

@tshuli
Copy link
Contributor Author

tshuli commented Jan 6, 2021 •
edited by mantariksh
Loading

@mantariksh

IE11 intranet specific tests for this week

  • Send login OTP multiple times. After 45 seconds you should see "OTP might be delayed due to government email traffic. If you are unable to sign in, please try again later, or contact us"

IE11 intranet general run-through

  • Create email mode form with all fields. Activate and submit form. Check that you can receive responses in your GSIB inbox.
  • Collaborators can be added in email mode.
  • Create storage mode form with all fields. Activate and submit form.
  • Response CSV can be downloaded for storage mode.
  • Responses can be viewed in Data tab in storage mode.
  • Attachments can be downloaded from Data tab in storage mode.
  • Submission IDs can be filtered in storage mode.
  • Collaborators can be added and their collaborating rights edited in storage mode.

@tshuli tshuli requested review from karrui and mantariksh and removed request for karrui January 6, 2021 04:40
@tshuli
Copy link
Contributor Author

tshuli commented Jan 6, 2021 •
edited by karrui
Loading

Migrate submissions controller to typescript
@karrui

  • Create an email mode form with 3 email fields: one with email confirmation but no PDF, one with email confirmation and PDF, one without email confirmation. Also add an attachment. Check that the correct email confirmation is sent to each email address, with the attachments.
  • Create a storage mode form with 2 email fields: one with email confirmation, one without. Check that the email confirmation is sent to the correct email.

@tshuli tshuli merged commit 7dde1e9 into release Jan 6, 2021
@liangyuanruo liangyuanruo deleted the release-4.52.0 branch January 14, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tshuli @mantariksh @liangyuanruo @snyk-bot @frankchn @jia1 @karrui